Weird behaviour in bilinear_interp.py about pytmd

[tommy307507]

In line 384 of read_tide_model.py, there is a missing [:] after v1.data causing the error:
AttributeError: can't set attribute
v1.data = bilinear_interp(xi,yv,v,x,y,dtype=np.complex128)

proposed fix:
adding the [:], this also matches the syntax used in line 324 for u1.data

[tommy307507]

I would want to add in read_tide_model.py there's also this issue of len(npts) being used incorrectly. The fix would be changing npts = len(D) to npts = D.shape , and adding an asterisk (*) to before the npts used in the assignment of placeholder matrices. i.e.
np.ma.zeros((*npts,nc)....) and np.ma.zeros((*npts),...)
below to use the starred expression.
Thanks for the package but I had a hard time figuring this out …

[tsutterley]

Hi @tommy307507, sorry I'm out of town so I'm a little slow on responses.

These are good points. I typically flatten the input fields so I don't run into the shape issues. It's a good point that I should add some logic for different shaped fields for people not using the "higher order" programs for computing heights or currents. I should also update the documentation so that people don't run into the problems you've noted.

I'll definitely fix the attribute error as soon as I get back in the office. Or if you want to put a PR in to fix it that would be great too.