Keyboard UI for deleting entries about gnome-shell-extension-clipboard-indicator

[Tudmotu]

Wow @orpic , that's awesome!
I tested it as well and seems to work. Can you please open a PR so I can merge? 🙏

[schlagmichdoch]

@orpic Thanks for implementing this!

One issue:
If I delete an entry of the list via keyboard, the very last item of the list is selected instead of the next item on the list. This makes deleting a little bit confusing. Would be awesome if you could fix that!

Ubuntu 23.10
GNOME 45.rc
Wayland

[orpic]

Hi @schlagmichdoch
Thanks for pointing it out, I intended to move the selection to the next item, seems like I missed it while testing.
Let me take a look at it

[Tudmotu]

@orpic please note I am making some change around the area you previously modified so please make sure to merge the latest version.
Also, regarding the bug, maybe look at how the PopupMenu class is handling a similar scenario? Not sure if it will work but looks relevant:
https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/ui/popupMenu.js?ref_type=heads#L903

[Tudmotu]

Makes sense.

[orpic]

I want to work on this, can you assign it to me?

[Tudmotu]

@orpic thank you for considering contributing!

I would love for you to work on this, but right now the extension is in the process of being migrated to GNOME 45.

This means you would either:

1. Have to wait for GNOME 45 to be released before starting to work on it
2. If you want to start working on it already, you need to branch off from the gnome45 branch and test it on a system with GNOME 45.beta (one option is to use GNOME OS Nightly via GNOME Boxes).

Assigning this to you for now. Let me know what you decide.

[Tudmotu]

BTW the relevant place to add this I believe would be here inside the _addEntry function:
https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator/blob/a59954fb8a8595caeadb16fc255973463674f81d/extension.js#L396C33-L397C33

Probably need to connect to the key-press-event signal on the actor.
Not 100% sure this will work, would have to try it out.

Feel free to reach out if you need any assistance.

[orpic]

@Tudmotu Thank you for the response!

I will be testing it with GNOME OS Nightly via GNOME Boxes.
As you suggested I will start by connecting the key-press-event signal on the actor.

If I encounter any challenges or have questions along the way, I'll be sure to reach out for assistance.
Thanks again for your support!

[orpic]

Hi @Tudmotu

I am ready for a PR.
You can see the changes here: Link to changes

1. Pressing the Delete key when on a highlighted entry removes the entry
2. After the entry is removed the focus shifts to the next item and if empty then to the private mode

Tested it on GNOME OS Nightly ( via GNOME Boxes )

[orpic]

@Tudmotu
Sure, will take care of the merge, also thanks for the headsup will look into PopupMenu class first.

[orpic]

Hi @Tudmotu

I have created a PR for the bug, can you take a look at it? Link to PR