Wrong source file filtering when source directory contains a subdirectory with name ends with `Target.validSourceExtensions` about tuist

[fortmarek]

I would probably do it directly in Target+Core.swift instead of providing a new option in the glob behavior.

[fortmarek]

Hey 👋

Yeah, that looks like a valid issue (I'm still being surprised every day by some of the decisions of package authors). Would you want to take a look?

I wouldn't fix this at the ProjectFileElements level but instead wherever we expand the source file glob, we should do a case-sensitive comparison. Before we do that, I'd double check how vanilla SPM works if a package has an actual Swift file called "MyFile.Swift`. Does it pick up? If so, then instead of doing a case sensitive comparison, we would need to check if a given path is a file or a directory.

[danieleformichelli]

Hey 👋

Yeah, that looks like a valid issue (I'm still being surprised every day by some of the decisions of package authors). Would you want to take a look?

I wouldn't fix this at the ProjectFileElements level but instead wherever we expand the source file glob, we should do a case-sensitive comparison. Before we do that, I'd double check how vanilla SPM works if a package has an actual Swift file called "MyFile.Swift`. Does it pick up? If so, then instead of doing a case sensitive comparison, we would need to check if a given path is a file or a directory.

Can't we check whether it's a file or a directory rather than relying on case?
not 100% sure, but I think Xcode/SPM also accepts upper case, at least for some extensions

[fortmarek]

Can't we check whether it's a file or a directory rather than relying on case? not 100% sure, but I think Xcode/SPM also accepts upper case, at least for some extensions

Yeah, we can, that's what I said we could also do 😄 I'm not sure how fast the isDirectory operation is because we would technically need to run it for every file, so even if it's fast, it could compound. But maybe it's fast enough that it wouldn't add to the generation time.

If SPM/Xcode pick up files with .Swift extension, then we can't rely on case-sensitive compare of the extension, yeah.

[kyounh12]

Looks like vanilla SPM accepts uppercased .Swift extension. So now we should check if the path is directory or a file.

I'm not sure which place would be the best to run the check.

1. Add an extra guard statement below Target+Core.swift L:85 to filter out paths that are directories.

.filter { path in
    guard let `extension` = path.extension else { return false }
    guard !FileHandler.shared.isFolder(path) else { return false } // Adding this line solves the problem
    return Target.validSourceExtensions
        .contains(where: { $0.caseInsensitiveCompare(`extension`) == .orderedSame })
}

2. Add behavior: Glob.Behavior parameter to throwingGlob function and pass a behavior with includesDirectoriesInResults set to false when getting paths from glob execution. ( Target+Core.swift L:75 )

I tested both implementations and all of them worked as expected