GithubHelp home page GithubHelp logo

Comments (5)

tuomount avatar tuomount commented on July 23, 2024 1

Let's go with ?.?.?-SNAPSHOT and one version bump per release cycle. I am also okay removing the Beta version suffix.

from open-realms-of-stars.

tuomount avatar tuomount commented on July 23, 2024 1

Update 0.25.0 into changelog. Change log is now just empty for 0.26.0. I was thinking to add that title there when we actually have something for change log, but there is always a chance it forgets from there, like 0.24.0Beta was forgotten from the change log. Closing this one.

from open-realms-of-stars.

tuomount avatar tuomount commented on July 23, 2024

Idea was that only stable versions have published releases. I think that those version between stable ones should be distinct somehow. How git commit identifier could be get into version number? I would guess it would require some plug-in to maven. For example 0.24.21Beta-c6705cbf would be excellent. I admit that I have been quite lazy with Maven, and I even found it is easier to manually pump up third number in version everyday when I make changes, than looking for maven plug-in for it. 😄

Another thing I would like to have is that there would another command like mvn verify, but it would not run full game JUnits since those can take quite a time depending on your CPU. But those are good when making AI changes or something else big game feature changes.

from open-realms-of-stars.

BottledByte avatar BottledByte commented on July 23, 2024

For example 0.24.21Beta-c6705cbf would be excellent

I can offer you to have ?.?.?-SNAPSHOT version label format for local developer builds and ?.?.? for official GitHub Releases, where you have to do only 1 commit with version bump per release cycle, each time after you do a GitHub Release. You would just have to run release build with different command (since you do Releases by hand). This includes propagation of this information to the Game itself.

I can also make it that there is no version bump commit per release cycle and developer builds will be marked with Git commit SHA. No modifying version strings ever again. But will have to get me access to CI for that 😉

So, no more "daily version bump" commits?
And will you let me remove that Beta version suffix while at it? IMHO, it looks bad. 😄
You accept? 😉

from open-realms-of-stars.

BottledByte avatar BottledByte commented on July 23, 2024

@tuomount After release, it is necessary to update src/resources/resource/changelog.txt also with heading that has the version string of the last released version.

Without this, the changelog in game will look like this for developer builds, not mentioning the last released version:
image

Otherwise, I can confirm that in released version 0.25.0 the changelog looks OK. 👍

And congratulations to the release of 0.25.0. 🎉
... I will start sending more PRs. 😄

from open-realms-of-stars.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.