Dropdown: fix for IE7/8 dropdown & modified JS about bootstrap

[fat]

Yep -- this, along with ie8 support is already live in this branch: https://github.com/twitter/bootstrap/tree/misc_css_fixes

thanks however!

[fat]

On second thought -- i'll leave this open until we merge that branch in. :)

[necolas]

IMO, better to use a wrapper than an empty div that is positioned to provide the background.

The drop-down JS in that branch isn't going to work well if someone decides to have more than 1 dropdown option in the secondary nav and/or if you decide to pull the dropdown out into its own pattern.

[fat]

Yep -- i agree -- that's what we're doing in that branch:

https://github.com/twitter/bootstrap/blob/misc_css_fixes/lib/patterns.less#L19

[fat]

Also, the js is for demo purposes only -- we don't recommend anyone use any of the js.

You're of course welcome to check it out, but you really should be writing custom js for your particular application. In this case -- what's there is the simplest code for our given demo. :)

[necolas]

Yep -- i agree -- that's what we're doing in that branch:

Sorry, I think you misunderstood. I meant that a wrapper is probably preferable to an empty element...unless you've found some problems that it throws up.

you really should be writing custom js for your particular application

Ah, ok...CSS only. Should you not also be writing custom CSS ;) It would still be good to somehow decouple the dropdown pattern from the topbar pattern IMO. Although, that might not quite fit with your plans or aims this project.

[fat]

Ahh gotcha. Yeah -- good point about the element, i'll switch it to a wrapper.

Yeah the drop down is an interesting bit - and it's might be worth trying to decouple it more. For now, i think it's simple enough and a nice addition though.

[necolas]

For sure. I'll have a look at doing it and let you know if anything fruitful comes of it. If nothing comes of it, I'll just pretend I didn't even try.

[fat]

haha alright sounds good ;)

[fat]

Is this what you were thinking with the wrapper?

48c3c6f

[necolas]

Yeah pretty much...if it works

[fat]

this is all live now !