GithubHelp home page GithubHelp logo

Comments (4)

fat avatar fat commented on July 24, 2024

I wrote this javascript for this yesterday

!function () {
  var getTarget = function (target) {
    var i, popovers = document.querySelectorAll('.segmented-controller li');
    for (; target && target !== document; target = target.parentNode) {
      for (i = popovers.length; i--;) { if (popovers[i] === target) return target; }
    }
  };
  window.addEventListener("touchend", function (e) {
    var target = getTarget(e.target);
    if (!target) return;
    var active = target.parentNode.querySelector('.active');
    if (active) active.classList.remove('active');
    target.classList.add('active');
  });
}();

But then i decided you really probably want to be doing something with push state (going to a new page) when you are doing this tab stuff… so it only really makes sense in a demo context.

Unless you think it makes sense to have actual tabs which are in page and which we toggle the display of…

from ratchet.

dhg avatar dhg commented on July 24, 2024

Right. Connor and I talked about this briefly. We could totally do traditional all in-page tabs (a la above code), but it would be really sick to be able to use the push state stuff.

from ratchet.

fat avatar fat commented on July 24, 2024

Ok - well the push stuff should just work then… so close?

from ratchet.

dhg avatar dhg commented on July 24, 2024

Yeah, I think that should be fine. We just need to test it and make sure we document how they work!

from ratchet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.