GithubHelp home page GithubHelp logo

Comments (7)

tweedge avatar tweedge commented on July 23, 2024

Hi! I'll have a look into this :)

from unishox2-py3.

tweedge avatar tweedge commented on July 23, 2024

So I have added a source distribution, but I'm still getting familiar with Conda. I am happy to be mentioned as a maintainer if you create a Conda package before me!

from unishox2-py3.

oschwengers avatar oschwengers commented on July 23, 2024

Sorry, for the late reply!

I just opened a PR to @conda-forge: conda-forge/staged-recipes#20798

The PR template contains a couple of questions regarding statically linked 3rd-party libraries that might be used and contained. I wonder if you could maybe check my statements and amend them where necessary?

Thanksa lot for your support and best regards!

from unishox2-py3.

oschwengers avatar oschwengers commented on July 23, 2024

@tweedge Unfortunately, I got stuck in the Windows CI tests. I'm neither a windows user nor do I have much experience with Python/C hybrid projects. Could you maybe have a look at this to figure out what's the issue here? Otherwise, I'd skip the Windows builds, but as a consequence, unishox-py3 would not be available for Windows.

from unishox2-py3.

tweedge avatar tweedge commented on July 23, 2024

Howdy, the answers given in this PR looks pretty good! I think we might be able to check off "Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)." as both projects use the same Apache 2.0 license, which is bundled.

Unfortunately I am also not a Windows user, so it might be best for us to accept the gap at this time :(

from unishox2-py3.

oschwengers avatar oschwengers commented on July 23, 2024

OK, I skipped the builds for Win and arm64 systems and requested a review. Let's see what we get.

from unishox2-py3.

oschwengers avatar oschwengers commented on July 23, 2024

Hi @tweedge , sorry fore the very late reply. There were a comment regarding different licenses: conda-forge/staged-recipes#20798 (comment)

Essentially, they ask if you could add the original Unishox2 license into your repo, because they differ due to different license holders (which is the case, see https://github.com/siara-cc/Unishox2/blob/72313797a9b305a3b36b697fc658b29490194de4/LICENSE at the very end: Copyright 2019 Siara Logics (cc)

If you would be willed to include the original license file as well, we might go ahead with conda-forge/staged-recipes#20798

from unishox2-py3.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.