Comments (5)
Thanks for the report.
I am not sure that serverFromString
is designed to provide such a level of customization.
In all my use cases, I am using serverFromString
only for quick testing code. Never in production, where it needs a high degree of configuration.
Can you suggest what would be the expected string that will include custom ciphers?
OpensSSL cipher configuration is something like this HIGH:!PSK:!RSP:!eNULL:!aNULL:!RC4:!MD5:!DES:!3DES:!aDH:!kDH:!DSS
... but we already use the colon (:) as a separator ... maybe use a comma
ssl:443:privateKey=key.pem:certKey=crt.pem:cipher=HIGH,!PSK,!DSS
Feel free to summit a PR with a possible solution for this.
Regards
from twisted.
I am not sure that
serverFromString
is designed to provide such a level of customization.
Design-wise, any static configuration like this should be doable from the Twisted-provided plugins for serverFromString
. The one place where extra customization for serverFromString
is out of scope would be things like per-connection state or changing parameters based on the peer; basically if you need to run Python code to figure out your parameters you need to use a different API, we shouldn't have Python functions to call stuffed into the string. But a static ciphersuite selection string is a perfectly reasonable parameter to have in there.
(I will say that for most users we should be providing good defaults and strongly encouraging usage of those defaults so we can evolve them to be up-to-date in terms of consensus security practices, but it sounds like @KaviHarjani has a very clear and specific idea of what they want here)
from twisted.
Hey guys this is my first open-source contribution
Thank you for giving me this opportunity @glyph @adiroiban
I didn't make many changes but the tests seem to have been failing for Windows and Macos
Could you guys help me here
from twisted.
thank you @KaviHarjani !
from twisted.
Could you guys help me here
The failures that you are pointing at are not on Windows & macOS, they are failures on every platform that runs with SSL. The message, twisted.trial.unittest.FailTest: (<twisted.internet.endpoints.SSL4ServerEndpoint object at 0x7f8a4e0add00>,) is not an instance of <class 'twisted.internet.endpoints.SSL4ServerEndpoint'>
, is showing you that the object you are asserting about is a 1-element tuple containing the endpoint rather than the endpoint itself.
from twisted.
Related Issues (20)
- twisted.internet.test.test_process fails on Python 3.13
- Resolve "Twisted: NEXT" from documentation HOT 4
- Update cryptography imports in twisted.conch HOT 3
- Automat 24.8.0 breaks with Twisted 23.8.0 HOT 5
- Consolidate codecov.io reporting
- Feature: web/_flatten: Evaluate deferreds from Element methods asynchronously? HOT 4
- Typo in `_istoken` causes valid HTTP requests to be rejected.
- twisted.internet.endpoints.HostnameEndpoint.connect() uses quite a lot of CPU HOT 3
- Add support for FIDO2 certificate based sk auth for SSH server
- Fix coverage upload for our tests HOT 1
- test_http11_server_chunked_request is still flaky
- deprecated ciphers causing runtime messages HOT 3
- Disable Nagle in HTTP client and server HOT 2
- test_manhole.py is failing with latest 3.13 pre-release (rc2)
- After the TLS protocol is configured, there is a 10-minute delay in continuous data transmission HOT 1
- Issues for building twisted on 24.7.0 windows . errors for cython-test-exception-raiser HOT 1
- More small twisted.web optimizations
- HostnameEndpoint doesn't respect scope ID received during name resolution HOT 1
- rpc example doesn't work anymore HOT 5
- twisted.trial._dist.test.test_stream.StreamTests.test_stream is flaky HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twisted.