http logger should respect the encoding of its log outputs about twisted

[michelcrypt4d4mus]

thanks - i tested out the changes from with #12198 and my problems are solved

[michelcrypt4d4mus]

I forked the codebase and put in the small change and everything seems OK for my use case though I'm too concerned about unforeseen side effects and unclear on how to test etc. to open a PR.

[adiroiban]

Hi,

Thanks for the report.

I would say that the call should be just logFile.write(line)
Then, the logFile should do its magic to make sure the line is stored into the expected encoding.

And just open the log in text mode here

twisted/src/twisted/web/http.py

Lines 3304 to 3309 in c465c46

	def _openLogFile(self, path):
	"""
	Override in subclasses, e.g. to use L{twisted.python.logfile}.
	"""
	f = open(path, "ab", 1)
	return f

---

logFile._encoding is a private API

---

Don't worry to much about breaking things.

If you send a PR with good test coverate and for changes which pass on the existing tests, the PR should be good to merge.

---

As a side note, I don't know why the Twisted HTTP is not using the standard logging infrastructure, and instead uses a custom file.

I am using the server in production, but I have just overwritten the factory not to handle the logs in a separate file.

Thanks again!

[glyph]

Whew. OK, there are a couple of mixed-up issues here.

• HTTPFactory really needs to delegate some of its logging responsibilities to a dedicated object, which can implement structured logging methods. NSLog is capable of outputting structured information, and it's a bit sad it has to log everything with "@" as its format string. In HTTP/3 you still need to log requests, but the server is not going to be a "Factory" at all.
• why is the log file being opened in binary mode when we are encoding everything we are writing to it?

[glyph]

• why does log silently discard its logs?