ReactorAlreadyInstalledError about txacme

[mithrandi]

This seems to be fixed in master already (I can reproduce with txacme 0.9.0, but not with master), but I don't actually know what's going on here, so it may still warrant further investigation.

[glyph]

I can reproduce with master. Try mktmpenv; pip install git+https://github.com/mithrandi/txacme; twist --help ?

[glyph]

Actually it's pretty straightforward. When building the plugin cache, we get the traceback because the txacme endpoint plugin imports twisted.web.client (among other things) that installs the reactor at module scope. Once the cache is built it's fine.

[mithrandi]

Oh, that explains it; I was using a -e install so the plugin cache was already built.

[mithrandi]

So uh... how do we actually fix this?

[mithrandi]

I guess I can move the endpoint parser into its own module, and it can lazily import everything else.

[glyph]

Yeah, plugins just have to be lazy about almost everything. Or we could make Twisted comprehensively forbid importing the reactor at module level :)

[glyph]

Thanks!!