Dictionary popup of TUITextRenderer does not work on 10.7.3? about twui

[avaidyam]

Mmm, mind posting the code you used to configure this? (Partially because I haven't been able to get it to work either, and partially to help you :D)

[devon]

I tried the latest example from twui, it works. I use and old twui branch(before ARC). I'm trying to figure it out.

[avaidyam]

Wait, is it enabled automatically? Doesn't seem to do that for me...

[devon]

Yeah, it enabled automatically. git clone the latest version from https://github.com/twitter/twui.git, and run the example project.

[avaidyam]

Oh, I see. I will indeed do that. Was the triple-tap define on the table view cell labels?

[devon]

Yeah, triple-tap on the table view, it will show up the dictionary. I think it's related to TUITextRenderer

[avaidyam]

Alright, will look into that and get back to you. I'm on a desktop at the moment, but tomorrow I'll test it on an MBP running 10.7.3.

[devon]

I found the problem. Cannot popup the dictionary when add line height to TUIAttributedString.

ExampleTableViewCell *cell = reusableTableCellOfClass(tableView, ExampleTableViewCell);

TUIAttributedString *s = [TUIAttributedString stringWithString:[NSString stringWithFormat:@"good news cell %d", indexPath.row]];
s.color = [TUIColor blackColor];
s.font = exampleFont1;
s.lineHeight = 3;  // Add the line will see the problem
[s setFont:exampleFont2 inRange:NSMakeRange(8, 4)]; // make the word "cell" bold
cell.attributedString = s;

return cell;

[avaidyam]

Considerably faster than I could, I see. Now that we know that the issue is here, I can look into fixing it. Thanks!

[devon]

Change the setLineheight to use the default method solve the problem, but i'm not sure is this a good solution for this:

- (void)setLineHeight:(CGFloat)f inRange:(NSRange)range
{
    // CTParagraphStyleSetting setting;
    // setting.spec = kCTParagraphStyleSpecifierLineSpacing;
    // setting.valueSize = sizeof(CGFloat);
    // setting.value = &(CGFloat){f};

    // CTParagraphStyleRef paragraphStyle = CTParagraphStyleCreate(&setting, 1);
    // [self addAttributes:[NSDictionary dictionaryWithObjectsAndKeys:(id)paragraphStyle, kCTParagraphStyleAttributeName, nil] range:range];
    // CFRelease(paragraphStyle);
    NSMutableParagraphStyle *p = [[NSParagraphStyle defaultParagraphStyle] mutableCopy];
    [p setLineSpacing:f];
    [self addAttributes:[NSDictionary dictionaryWithObjectsAndKeys:(id)p, kCTParagraphStyleAttributeName, nil] range:range];
    [p release];
}

[joshaber]

This is fixed after merging #107