GithubHelp home page GithubHelp logo

Comments (7)

NSProgrammer avatar NSProgrammer commented on June 22, 2024 2

OK, should be done.

from ios-twitter-image-pipeline.

NSProgrammer avatar NSProgrammer commented on June 22, 2024

Yes, please. We are spread thin and unable to keep on top of cocoa pods support

from ios-twitter-image-pipeline.

liamnichols avatar liamnichols commented on June 22, 2024

I'm happy to pick this up... I ran pod spec lint and it flagged up warnings about unguarded availability checks and after adding CLANG_WARN_UNGUARDED_AVAILABILITY to TwitterImagePipeline.xcconfig I got the 9 compile errors to show up.

All these errors relate to use of new APIs introduced in iOS 10 so @NSProgrammer would you prefer that I dig into these and look to try and keep iOS 8 and 9 support or can we just bump the minimum iOS deployment target to iOS 10?

Given that Xcode 12 drops iOS 8 support I think it'll probably be better (and easier) to just support iOS 10+ as we'd have to consider upping it to iOS 9 anyway.. I'm not sure what the official stance on this is though

from ios-twitter-image-pipeline.

NSProgrammer avatar NSProgrammer commented on June 22, 2024

We have an upcoming release for TIP that will also drop iOS 8 & 9 support. Let’s wait for that to land. Hopefully that will make it easier.

from ios-twitter-image-pipeline.

liamnichols avatar liamnichols commented on June 22, 2024

Awesome, that sounds like a good plan.

Please let me know if there is anything else that you need help with in terms of getting a CocoaPod's release out when the time comes, thanks!

from ios-twitter-image-pipeline.

NSProgrammer avatar NSProgrammer commented on June 22, 2024

v2.24.0 has been released. If you are able to update the CocoaPod's for TIP, that would be very welcomed. Thanks!

from ios-twitter-image-pipeline.

liamnichols avatar liamnichols commented on June 22, 2024

@NSProgrammer: Thanks for the new release! I linted the spec on master and all looks good:

$ pod spec lint            

 -> TwitterImagePipeline (2.24.0)
    - NOTE  | [TwitterImagePipeline/Default] xcodebuild:  note: Using new build system
    - NOTE  | [TwitterImagePipeline/Default] xcodebuild:  note: Building targets in parallel
    - NOTE  | [TwitterImagePipeline/Default] xcodebuild:  note: Planning build
    - NOTE  | [TwitterImagePipeline/Default] xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  note: Build description constructed in 0.223138173s
    - NOTE  | [iOS] xcodebuild:  note: Using build description '9985b1ca1524a24f7429e027bb521fa3'
    - NOTE  | [TwitterImagePipeline/Default] xcodebuild:  note: Using eager compilation
    - NOTE  | [TwitterImagePipeline/Default] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')
    - NOTE  | [iOS] [TwitterImagePipeline/Default] xcodebuild:  note: Build description constructed in 0.203846421s
    - NOTE  | [iOS] [TwitterImagePipeline/Default] xcodebuild:  note: Using build description 'b801f9deee45ce8f33e6164b19105d12'

Analyzed 1 podspec.

TwitterImagePipeline.podspec passed validation.

Only you (nsprogrammer [at] nsprogrammer [dot] com) or Twitter (cocoapods-owner [at] twitter [dot] com) are listed as owners of this library so you'll have to be the one who runs pod trunk publish... It should be as simple as that I think 🙏

If you get auth errors on your machine, run pod trunk register and provide the email address above to authenticate a valid session

from ios-twitter-image-pipeline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.