Cannot find module 'snabbdom-to-html' when installing from NPM about cycle-snabbdom

[TylorS]

@acstll This might be of interest to you as well. Seems to be related to updating to snabbdom-to-html 2.1.0

[TylorS]

@kaosat-dev Could you run npm ls and tell me what version of snabbdom-to-html is installed?

[kaosat-dev]

yes : [email protected]

[TylorS]

Could you try explicitly installing [email protected] and reporting back if the error still exists?

[kaosat-dev]

Tried it, error still stays the same

[kaosat-dev]

edit: never mind my bad, even with older snabbdom-to-html versions it still fails

[TylorS]

It's exactly the same error?

Do you mind posting it?

[kaosat-dev]

exactly the same : Full error message is :

Error: Cannot find module 'snabbdom-to-html' from '/home/xxx/dev/projects/GreenBotics/automaton/node_modules/cycle-snabbdom/lib'

[kaosat-dev]

Btw , if you cannot reproduce on your end, perhaps I can try a barebone version to see if it might be my browserify setup ?

[TylorS]

I can only reproduce with snabbdom-to-html 2.1.0

[acstll]

@TylorS hey, I will take a look tomorrow morning and make sure 2.1.0 is correctly published and working (I'm away now).

Seems like a problem indeed with my package, I tried it in requirebin.com and got that same error.

Sorry about this!

[TylorS]

~/code/tylors/cycle-snabbdom master*
❯ npm ls | grep snabbdom-to-html
├─┬ [email protected]

~/code/tylors/cycle-snabbdom master*
❯ npm run dist

> [email protected] predist /home/tylor/code/tylors/cycle-snabbdom
> rm -rf dist/ && mkdir dist/


> [email protected] dist /home/tylor/code/tylors/cycle-snabbdom
> browserify -t [babelify --global] -t browserify-shim --exclude rx --standalone CycleSnabbdom src/index.js -o dist/cycle-snabbdom.js

Error: Cannot find module 'snabbdom-to-html' from '/home/tylor/code/tylors/cycle-snabbdom/src'
    at /home/tylor/code/tylors/cycle-snabbdom/node_modules/resolve/lib/async.js:46:17
    at process (/home/tylor/code/tylors/cycle-snabbdom/node_modules/resolve/lib/async.js:173:43)
    at ondir (/home/tylor/code/tylors/cycle-snabbdom/node_modules/resolve/lib/async.js:188:17)
    at load (/home/tylor/code/tylors/cycle-snabbdom/node_modules/resolve/lib/async.js:69:43)
    at onex (/home/tylor/code/tylors/cycle-snabbdom/node_modules/resolve/lib/async.js:92:31)
    at /home/tylor/code/tylors/cycle-snabbdom/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:82:15)

~/code/tylors/cycle-snabbdom master* 9s
❯ npm ls | grep snabbdom-to-html
├─┬ [email protected]

~/code/tylors/cycle-snabbdom master*
❯ npm run dist

> [email protected] predist /home/tylor/code/tylors/cycle-snabbdom
> rm -rf dist/ && mkdir dist/


> [email protected] dist /home/tylor/code/tylors/cycle-snabbdom
> browserify -t [babelify --global] -t browserify-shim --exclude rx --standalone CycleSnabbdom src/index.js -o dist/cycle-snabbdom.js


> [email protected] postdist /home/tylor/code/tylors/cycle-snabbdom
> uglifyjs dist/cycle-snabbdom.js -o dist/cycle-snabbdom.min.js

[TylorS]

Thank you @acstll. Let me know if there is anything I can do to help?

[acstll]

2.1.0 is indeed broken, the lib folder is missing from the package.

I will publish 2.1.1 and depracate ASAP.

[TylorS]

👍

[TylorS]

Thank you @acstll

[acstll]

The main export (toHMTL) should work in 2.1.2. But init and the modules won't. I need to figure out how to set up the browser key in package.json. I could use some help here :-)

I will release 2.2.0 when it's fully working and deprecate all 2.1.x in npm.

[TylorS]

@acstll I'll do some reading 👍

[kaosat-dev]

thanks a lot for the infos @TylorS and @acstll !
Let me know if I can also help with something!

[the-simian]

Ah, looks like I was slow to move. this is the same issue I was experiencing as well, but it was being manifest as a build error.

I wanted to just add that the unit tests in here were passing for me, but the stuff testem kicked off were failing. This was after cloning the repo, while trying to troubleshoot (after experiencing the issue after pulling from npm)

[TylorS]

This should be fixed with v1.1.0
Please let me know if there are anymore issues.

[acstll]

I just created an issue to keep track of the bug. I will let you kwow when I figure it out. Thank y'all.

[kaosat-dev]

@TylorS it seems to work ok now, thanks !
Should this get closed or remain open for @acstll updates ?

[TylorS]

I'll close for now. If for any reason anyone needs to reopen or continue discussing, feel free.