GithubHelp home page GithubHelp logo

Comments (7)

swyxio avatar swyxio commented on April 16, 2024

yeah I get mixed messages from the community on this. I like to assign when destructuring, but others like to use defaultProps. want to put in a PR?

from react.

 avatar commented on April 16, 2024

Putting this as a comment but willing to propose a PR if @rssfrncs is not taking this.

interface IMyComponentProps {
  firstProp: string;
  secondProp: IPerson[];
}

export class MyComponent extends React.Component<IMyComponentProps, {}> {
  static defaultProps: Partial<IMyComponentProps> = {
    firstProp: "default",
  };
}

from react.

tsiq-swyx avatar tsiq-swyx commented on April 16, 2024

I dont use defaultProps myself but just wanted to add that the Spectrum community also suggested adding a withDefaultProps type HOC: https://twitter.com/code_punkt/status/1000105182565490688

also, here is a slightly longer approach also using Omit: https://levelup.gitconnected.com/ultimate-react-component-patterns-with-typescript-2-8-82990c516935

Yours seem much simpler!

would love a PR here, this is the top requested info based on feedback from reddit/hn/twitter/spectrum

from react.

rssfrncs avatar rssfrncs commented on April 16, 2024

@Attrash-Islam go ahead with a PR buddy!

from react.

 avatar commented on April 16, 2024

@rssfrncs Thanks! I will do it tomorrow after reviewing the whole repository so it match the README with the other section in the same format 😉

from react.

rssfrncs avatar rssfrncs commented on April 16, 2024

Have you checked out this similar repo? It has an interesting approach to default props. Whilst it is focused on Redux React apps there is a lot of overlap.

from react.

 avatar commented on April 16, 2024

The way they do it is not that good since you need to update your DefaultProps interface every time you want to include additional prop (see how initialCount: number is duplicated).

My suggestion is using Partial type feature which gives you to extends the defaultProps whenever you want without any additional type extensions

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.