GithubHelp home page GithubHelp logo

Comments (14)

tyrauber avatar tyrauber commented on June 27, 2024

@hlandgar, Any more details? I installed 1.1.8 and ran the same query in irb successfully.

from stock_quote.

hlandgar avatar hlandgar commented on June 27, 2024

Seeing the same error both locally and on heroku. Started yesterday. Just check again and it is working. Yahoo must have has a temporary certificate issue that they fixed overnight. BTW, nice gem.

Best,

Harris

Harris Landgarten
LHJ Technology Solutions, Inc.
516 299-8390

----- Original Message -----
From: "Ty Rauber" [email protected]
To: "tyrauber/stock_quote" [email protected]
Cc: "hlandgar" [email protected]
Sent: Friday, November 7, 2014 12:40:48 AM
Subject: Re: [stock_quote] ssl error accessing yahoo finance (#18)

@hlandgar, Any more details? I installed 1.1.8 and ran the same query in irb successfully.


Reply to this email directly or view it on GitHub:
#18 (comment)

from stock_quote.

tyrauber avatar tyrauber commented on June 27, 2024

Glad it's sorted!

from stock_quote.

dcu avatar dcu commented on June 27, 2024

I'm still getting the same error :/ I think it's a problem in yahoo's side. Is there a way to disable the SSL verification?

Chrome marks this as unsafe: https://query.yahooapis.com/v1/public/yql

from stock_quote.

hlandgar avatar hlandgar commented on June 27, 2024

Issue back for me too. Could be yahoo does certificate maintenance of some kind but you should take a look.

Harris Landgarten
LHJ Technology Solutions, Inc.
516 299-8390

----- Original Message -----
From: "David Cuadrado" [email protected]
To: "tyrauber/stock_quote" [email protected]
Cc: "hlandgar" [email protected]
Sent: Friday, November 7, 2014 5:17:01 PM
Subject: Re: [stock_quote] ssl error accessing yahoo finance (#18)

I'm still getting the same error :/


Reply to this email directly or view it on GitHub:
#18 (comment)

from stock_quote.

tyrauber avatar tyrauber commented on June 27, 2024

Odd. Just checked again, and everything is working fine for me. Maybe it is a regional issue?

@hlandgar, @dcu, Are you able to make a query to yahooapis.com directly?

from stock_quote.

hlandgar avatar hlandgar commented on June 27, 2024

I just checked and it is working again for me. Either yahoo is screwing around with certificates or maybe some of their servers have good certs and some not. It seems to be a yahoo issue in any case but not regional. You might want optionally trap this error and see if the data is good.

Harris Landgarten
LHJ Technology Solutions, Inc.
516 299-8390

----- Original Message -----
From: "Ty Rauber" [email protected]
To: "tyrauber/stock_quote" [email protected]
Cc: "hlandgar" [email protected]
Sent: Friday, November 7, 2014 9:09:51 PM
Subject: Re: [stock_quote] ssl error accessing yahoo finance (#18)

Odd. Just checked again, and everything is working fine for me. Maybe it is a regional issue?

@hlandgar, @dcu, Are you able to make a query to yahooapis.com directly?


Reply to this email directly or view it on GitHub:
#18 (comment)

from stock_quote.

dcu avatar dcu commented on June 27, 2024

In the meantime this hack worked for me:

OpenSSL::SSL::VERIFY_PEER = OpenSSL::SSL::VERIFY_NONE

NOTE: it'll print a lot of warning messages saying it is unsafe

from stock_quote.

dcu avatar dcu commented on June 27, 2024

When querying yahoo from chrome I get this ssl error:

The identity of this website has not been verified.
• Server's certificate does not match the URL.

from stock_quote.

tyrauber avatar tyrauber commented on June 27, 2024

@dcu, @hlandgar, thanks for the additional info. Unfortunately, I don't think there is much I can do. Unfortunately, I can't recreate the issue, and if I could, it appears to be a DNS/SSL issue with yahoo.

The gem test suite uses VCR, so we could in fact capture the response. We would at least be able to confirm the response is invalid. You'd need to:

  • a) clone the repo: $ git clone [email protected]:tyrauber/stock_quote.git
  • b) delete the spec/support/vcr_cassettes directory
  • c) run the suite: $rspec

Just one of those VCR cassettes would allow me to debug the problem, and see if there was anything I can do.

EDIT:

With that being said, if you can't even open this url in a browser then the cassette isn't going to be much different.

If you are using this gem in production, you might want to take a look at this gem:
tradeking You'll need an api key from them, but service wise it will provide a lot more data than yahoo's api.

from stock_quote.

tyrauber avatar tyrauber commented on June 27, 2024

Scratch that. There is something we can do. We just need to tell RestClient not verify the SSL cert.

@dcu, @hlandgar, Can one of you confirm the fix in this branch, fix/verify_ssl, works?

In rails, in your GEMFILE:

     gem 'stock_quote', github: '[email protected]:tyrauber/stock_quote.git', branch: 'fix/verify_ssl'

Then bundle install.

If this fixes the issue, I'll merge it in and do a version bump.

from stock_quote.

hlandgar avatar hlandgar commented on June 27, 2024

It wasn't working but is now with the git fix so you most likely fixed it. And you didn't break anything.

Harris

Harris Landgarten
LHJ Technology Solutions, Inc.
516 299-8390

----- Original Message -----
From: "Ty Rauber" [email protected]
To: "tyrauber/stock_quote" [email protected]
Cc: "hlandgar" [email protected]
Sent: Friday, November 7, 2014 10:01:59 PM
Subject: Re: [stock_quote] ssl error accessing yahoo finance (#18)

Scratch that. There is something we can do. We just need to tell RestClient not verify the SSL cert.

@dcu, @hlandgar, Can one of you confirm the fix in this branch, fix/verify_ssl, works?

In rails, in your GEMFILE:

     gem 'stock_quote', github: '[email protected]:tyrauber/stock_quote.git', branch: 'fix/verify_ssl'

Then bundle install.

If this fixes the issue, I'll merge it in and do a version bump.


Reply to this email directly or view it on GitHub:
#18 (comment)

from stock_quote.

hlandgar avatar hlandgar commented on June 27, 2024

On further checking 1.18 is getting ssl errors on heroku but my local install with the git fix is working fine.

Harris

Harris Landgarten
LHJ Technology Solutions, Inc.
516 299-8390

----- Original Message -----
From: "Harris Landgarten" [email protected]
To: "tyrauber/stock_quote" [email protected]
Cc: "tyrauber/stock_quote" [email protected]
Sent: Friday, November 7, 2014 10:13:29 PM
Subject: Re: [stock_quote] ssl error accessing yahoo finance (#18)

It wasn't working but is now with the git fix so you most likely fixed it. And you didn't break anything.

Harris

Harris Landgarten
LHJ Technology Solutions, Inc.
516 299-8390

----- Original Message -----
From: "Ty Rauber" [email protected]
To: "tyrauber/stock_quote" [email protected]
Cc: "hlandgar" [email protected]
Sent: Friday, November 7, 2014 10:01:59 PM
Subject: Re: [stock_quote] ssl error accessing yahoo finance (#18)

Scratch that. There is something we can do. We just need to tell RestClient not verify the SSL cert.

@dcu, @hlandgar, Can one of you confirm the fix in this branch, fix/verify_ssl, works?

In rails, in your GEMFILE:

     gem 'stock_quote', github: '[email protected]:tyrauber/stock_quote.git', branch: 'fix/verify_ssl'

Then bundle install.

If this fixes the issue, I'll merge it in and do a version bump.


Reply to this email directly or view it on GitHub:
#18 (comment)

from stock_quote.

tyrauber avatar tyrauber commented on June 27, 2024

Awesome! Merged and bumped to version 1.2.0.

 gem 'stock_quote',  '~> 1.2'

Thanks @hlandgar and @dcu

from stock_quote.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.