tzi / chewing-grid.css Goto Github PK

Hey Thomas!

First, thanks for this great grid. First time I use it and I already love it.

Here's my feedback:

I noticed a difference between Firefox and Chrome when using min-width in .chew-cell elements (from your demo here: http://tzi.github.io/chewing-grid.css/demo.html). In Chrome, elements do have the same size while in Firefox they don't. Using flex-basis solves the "problem" (if we assume that it's a problem).

I spend few minutes to understand why elements on last row don't expand to fill the space (or why alignment was messed up when using justify-content on parent), then I discovered that .chew-card elements have max-width: 300px by default. It's not clearly explained in doc, maybe it's worth adding it or removing max-width by default? I could also have read more carefully the CSS. ;)

Related to this, I also noticed that alignment on parent (with justify-content) only works if .chew-cell elements have a max-width. I'm not sure if it's normal or not.

Hi,

I'm asking, if this replaces Herow. Just discovered Herow and I quite like it so far. Is this the same as Herow and Herow has become deprecated?

Hello,

Dans ton fichier /src/mixins/core/_cell.core.scss, tu appliques un reset des propriétés de inline-block.

Par contre, tu laisses text-rendering à sa valeur optimizelegibility, ce serait peut-être mieux de la resetter aussi à auto, non ?

Hello Thomas,

There's a little error in the doc at 2.E. Set a maximum card width section :

The example says chew-row chew-row--card-min-500 but should be chew-row chew-row--card-max-500

Further, at 3.C. Limit the column number you tell :

Change the cell flex-basis and the width to set a column limit

But the example only changes width value. Do we have to change flex-basis too ?

Have a nice day ;)