GithubHelp home page GithubHelp logo

Comments (7)

bcap avatar bcap commented on July 24, 2024 1

Ping!

Just found this library and it has helping me doing some basic ratelimiting, so thank you for that :)
I am feeling some other features are needed though here, context cancelation being one of them (if there is another lib or fork I should look at, please let me know!). If you are so inclined I can open other issues for features I think it would be nice to have

Regardless, for context cancelation I am currently resorting to this (used within an httpClient impl)

func (c *httpClient) applyRateLimit(ctx context.Context) error {
	// the following goroutine + select allow us to abort waiting on
	// rate limiting if the request context is done
	limitingDone := make(chan struct{})
	go func() {
		c.limiter.Take()
		close(limitingDone)
	}()

	select {
	case <-limitingDone:
		return nil
	case <-ctx.Done():
		return ctx.Err()
	}
}

from ratelimit.

rabbbit avatar rabbbit commented on July 24, 2024

For my future self - #11 tried to do the same. Some code has changed, but the comments there are valuable.

I don't see why we wouldn't extend the API to allow cancellation.

from ratelimit.

rabbbit avatar rabbbit commented on July 24, 2024

The API extension sounds reasonable, but this is not very high in my priority list - it'll likely take weeks if not months. PRs are welcome though :)

Happy to get more feature requests/issues - we can at least track them. But like above, I don't expect to be able to address them soon.

from ratelimit.

diamondburned avatar diamondburned commented on July 24, 2024

I can take on this issue. However, I'm not sure how Take() should behave.

I know that the signature could be TakeCtx(ctx context.Context) (time.Time, error). I'm unsure if I can just exit the function with an error or if I have to rollback the rate limit state since it technically errored out.

from ratelimit.

diamondburned avatar diamondburned commented on July 24, 2024

Also, why do we have 3 different implementations of Limiter? Do I update all of them? It appears that only one is used.

from ratelimit.

rabbbit avatar rabbbit commented on July 24, 2024

I would recommend using https://pkg.go.dev/golang.org/x/time/rate#Limiter.Wait if it fits your requirements instead.

Given recent issues with testing & complexity of the questions you listed above, we're likely to stay with the current minimal API.

from ratelimit.

diamondburned avatar diamondburned commented on July 24, 2024

I would recommend using https://pkg.go.dev/golang.org/x/time/rate#Limiter.Wait if it fits your requirements instead.

This is what I ended up using. I just forgot it existed.

It's still weird to me to use a blocking API without context support. That's just me, though.

from ratelimit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.