Comments (5)
Thanks for the bug report. We probably need to add a check in Travis CI to catch this kind of issue.
from h3-js.
Will this be addressed in any upcoming releases? Would love to have type enforcement when using this library in TypeScript (I'm stuck on 3.4.0
at the moment).
Thanks!
from h3-js.
Yes, I'd like to fix it in the next release. I'm not as familiar with TS as I ought to be - is there a standard type-checking step we could do in CI that would catch this?
from h3-js.
Nothing off-the-shelf AFAIK, but it's simple enough to add a script in package.json
, e.g.:
"scripts": {
// ...
"type-check": "tsc dist/types.d.ts"
// ...
}
I'm guessing you do an npm install
already in your CI, so you could add typescript
as a dev dependency to get tsc
in your local environment. If I run this command now, I get the following error output:
WorkMac:h3-js sanj$ tsc dist/types.d.ts
dist/types.d.ts:80:75 - error TS2314: Generic type 'Array<T>' requires 1 type argument(s).
80 function h3ToGeoBoundary(h3Index: H3Index, formatAsGeoJson: boolean): Array[];
~~~~~
dist/types.d.ts:137:36 - error TS2314: Generic type 'Array<T>' requires 1 type argument(s).
137 function polyfill(coordinates: Array[], res: number, isGeoJson: boolean): H3Index[];
~~~~~
dist/types.d.ts:149:83 - error TS2314: Generic type 'Array<T>' requires 1 type argument(s).
149 function h3SetToMultiPolygon(h3Indexes: H3Index[], formatAsGeoJson: boolean): Array[];
~~~~~
dist/types.d.ts:228:93 - error TS2314: Generic type 'Array<T>' requires 1 type argument(s).
228 function getH3UnidirectionalEdgeBoundary(edgeIndex: H3Index, formatAsGeoJson: boolean): Array[];
~~~~~
Found 4 errors.
from h3-js.
Thanks, this is perfect.
from h3-js.
Related Issues (20)
- some h3index values create distorted long horizontal line on map HOT 1
- compactCells throws error HOT 1
- Openlayers instead of Mapbox HOT 1
- Count the number of points in the aggregated bins of H3-hexagons HOT 3
- Upgrade emscripten to 3.X.X? HOT 7
- Integrating with google maps HOT 1
- How to replace firestore geofire with h3? HOT 3
- Potential memory leak in polygonToCells HOT 10
- Load and Display H3-JS binned dataset in Mapbox HOT 1
- Consider buffer radius in addition to H3 resolution when counting points in the aggregated bins of H3-hexagons HOT 2
- Inverted coordinates HOT 1
- H3-JS binning resoluion in OpenLayers HOT 1
- Incorrect result from polygonToCells for bigger screen/ higher dimensions HOT 6
- Error when passing zero area polygon to h3.polygonToCells HOT 2
- Does h3-js send any data to the server? HOT 1
- I am unable to load h3-JS in my quasar project HOT 3
- H3 with dynamodb
- Different output from h3-js and postgis using cellToBoundary function HOT 1
- Hexagons Resolution HOT 1
- Somthing is funky at the borders of the cells HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from h3-js.