GithubHelp home page GithubHelp logo

Comments (4)

anag004 avatar anag004 commented on May 18, 2024 2

Not sure if this is relevant, but we might need to make PiranhaJS aware of variable scope here. Without this, the following code

{ var featureFlag = "feature1-flag"; } // scope 1

// ...

{ var featureFlag = "feature2-flag"; } // scope 2

will be refactored incorrectly when cleaning up one of the flags. For example, when cleaning up "feature1-flag", featureFlag will be replaced by "feature1-flag" everywhere.

from piranha.

atrakh avatar atrakh commented on May 18, 2024 1

Not sure if this is relevant, but we might need to make PiranhaJS aware of variable scope here.

Good point... this is some of the magic I hand-waved away 😄

from piranha.

msridhar avatar msridhar commented on May 18, 2024

The escope library can be helpful for variable scopes:

https://github.com/estools/escope

from piranha.

ketkarameya avatar ketkarameya commented on May 18, 2024

@atrakh we can now perform this kind of cleanup in polyglot piranha.
However, on-boarding JS of Polyglot Piranha is pending.
I am closing this issue for now, since polyglot piranha allows developers to support for such cleanups.
Feel free to reopen this issue if you have further questions.

from piranha.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.