Comments (7)
I went all the way back to blimpy version 1.3.4 (earliest release) i.e. https://github.com/UCBerkeleySETI/blimpy/tree/1.3.4
The last commit for version 1.3.4 was on Nov 29, 2018.
The _setup_freqs
function referenced in the Waterfall object is an inherited function from a "Filterbank" object defined in an obsolete filterbank.py source file. When the latter was scheduled for obsolesence as part of a large reorganisation, several of its functions were moved to waterfall.py and elsewhere. It appears that _setup_freqs
was left out somehow. And, it might have been left out because it didn't match what the reference in Waterfall needed (guessing). If so, that code in Waterfall should have been removed.
The current Waterfall instantiation (__init__
) could use some additional diagnostic code.
So, the desired function seems to be to instantiate a new Waterfall object given a metadata (header) dict object and a complete data matrix as opposed to getting this from a file. This should be new code that is equivalent to the "if filename" section preceding it. Agree?
from blimpy.
Anyone reading this issue should not be distracted by the _setup_freqs
function that is defined in the Reader object of the blimpy/io/base_reader.py source file. Unfortunately, blimpy has some function names that are repeated at multiple levels and perform different functions.
from blimpy.
@Sofysicist
My question about this issue still needs resolution. I want to make sure that (a) I interpreted your request correctly and (b) this proposed capability is still of interest.
from blimpy.
Agree with your definition of the desired function here, thanks. I actually just ran into a need for this functionality again (making a waterfall object from an existing data array and header dictionary), so it is definitely still-of-interest!
from blimpy.
I was thinking about a simple interface to produce a blimpy Waterfall object. Inspiration came from https://github.com/UCBerkeleySETI/turboseti_stream/blob/main/turboseti_stream/doppler_finder.py, the Gnu Radio project of Summer 2021.
However, on second thought, we will go with a single Waterfall class with the existing parameters (simpler). I'll make it work with the supplied data matrix and metadata (header dict).
What are you planning to do with the Waterfall object? Plot? Save it to an .h5 file or .fil file?
from blimpy.
@Sofysicist
Ready for testing: blimpy 2.1.1.
from blimpy.
@Sofysicist
Reminder that blimpy 2.1.3 is ready for testing.
from blimpy.
Related Issues (20)
- Non/broken HDF5 input files need better diagnosis HOT 2
- Try to remove HDF5 files that cannot be fully written due to an exception
- Inadvertently, testing is using the previous release
- Utility stax has time-axis issues
- Emit more useful write-blob messages - Filterbank and HDF5
- GuppyFile.get_data() raises StopIteration HOT 3
- Need a tool for patching the header source_name in an HDF5 file
- Support FBH5 version 2.0 reporting HOT 1
- fil2h5, h52fil, dice, and bl_scrunch can mangle the output file name
- Enhance rawhdr to focus on critical header fields for rawspec
- guppi.py assumes that numbers without periods are integers
- examine_h5 in hdf_reader.py is loading too much data
- Plotting fails plt.show() and this should work for X-terminals HOT 3
- Typo in `waterfall.py` HOT 2
- Introduce Filterbank file downsampling capability
- Need to initialise more container fields for the data_array + header case for Waterfall
- Enhance dsamp to output SIGPROC (.fil) files as well as .h5 files
- Add detailed testing to streaming Waterfall objects
- bl_scrunch never really worked correctly! )-:
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blimpy.