Certificate validation (https.c) causing issues with build in v424 about kent

[NullModel]

Good Morning Grammatikati: I would be curious to know if the pre-built binaries: http://hgdownload.soe.ucsc.edu/admin/exe/linux.x86_64/ function on the v424 system ?

…

On 12/14/21 4:58 AM, Grammatikati Konstantin wrote: **Describe the bug** After updating to the latest kent_base version (424) out build script failed with error. On 423 everything working (logs below). ```c https.c: In function 'verify_callback': https.c:322:47: error: dereferencing pointer to incomplete type 'X509_STORE_CTX {aka struct x509_store_ctx_st}' X509_NAME_oneline(X509_get_issuer_name(ctx->current_cert), buf, 256); ^~

[galt]

Hello, Grammatikati!
What version of openssl are you using?
You can get it from the command line like this:

command-line-prompt> openssl version
OpenSSL 1.0.2k-fips 26 Jan 2017

[galt]

The reason the work around does not work in our code is that I renamed the variable "error_cert" to simply "cert", since it often has no error at all.

[Stikus]

Ubuntu 18.04 have openssl 1.1.1 September 2018 iirk.

[galt]

I have fixed it in the source code on master branch.
Do a git pull and try again.

Alternatively, if using the beta release branch, that will be patched tomorrow.

The issue is caused by openssl who obsoleted the ctx->current_cert in version 1.1 while still using it in their own code examples.

Thanks so much for the helpful example!
This will help other users who are compiling from source with openssl 1.1.

[Stikus]

Thanks for quick fix, we'll use it when it comes to base release - I assume week or two.

Btw - any chance that you implement not only tags but GitHub releases too?

This option for notification don't see tags - only releases - that's why ppl like me should manually test for new release:

[galt]

The beta branch has been updated with the fix.

[Stikus]

Closing issue due to fix, but will ask again about proper release feature, not only tags, @galt

[CarpeVida]

Hi @Stikus,
We have not implemented the GitHub release feature, only tags. Thanks for the suggestion. It certainly would make sense. I made a note of your request and we will consider it, though I cannot say if or when it will be available.
In any case, the v425 release occurred 1/18/22 and should include the fix Galt made. We normally operate on 3-week release cycles.
Please let us know if you have any comments or questions and thank you for using the Genome Browser. We really do appreciate suggestions and detailed bug reports.
Daniel Schmelter
UCSC Genome Browser