encode_query causing issues in OAuth.authorize_url! with params about oauth2

[scrogson]

Thanks for the report. I don't know the right answer at the moment but I will try to find out.

My gut tells me that the API should handle both. But maybe I need to fix it on my end.

[meatherly]

@waynehoover how are you specifying your params? I was looking through the docs for URI.encode_query/1 and it looks like it shouldn't encode the + sign. Take a look and tell me if you're seeing the same thing https://github.com/elixir-lang/elixir/blob/v1.1.1/lib/elixir/lib/uri.ex#L61

[waynehoover]

@meatherly the query string is getting passed via options to OAuth.authoriz_url! as a string like "foo+bar+baz" which in turn produces this:

iex(2)> URI.encode_query(scope: "foo+bar+baz")
"scope=foo%2Bbar%2Bbaz"

Also reading the source I think I understand why + is escaped, because + is somewhat a special character in URIs, it is being used to represent spaces in urls, as you can see %20 i.e. space is being replaced by "+" manually https://github.com/elixir-lang/elixir/blob/v1.1.1/lib/elixir/lib/uri.ex#L191

For example:

iex(4)> URI.encode_query(param: "foo bar+baz")
"param=foo+bar%2Bbaz"

So this means to answer my original question and possibly close this ticket, if I pass scope: "foo baz" to OAuth.authorize_url! I will get what I want, i.e. + separated list. @scrogson feel free to close.