GithubHelp home page GithubHelp logo

Comments (5)

Virviil avatar Virviil commented on September 2, 2024 1

@sobolevn Basically saying I changed cassettes directly, instead of running the code with my token. So, I think that the best testing strategy will be run it with real VK requests.
I can try to do it myself - but then I'll ask you to make testing.md file with description how to add tokens, which tests to run and so one.

The fastest fix is to add one more handle_callback! implementation without state in pattern matching.
Better way will be to test different VK responses and develop suitable code.

from ueberauth_vk.

sobolevn avatar sobolevn commented on September 2, 2024

Oh, I see. @JustMikey can you provide a fix?

This feature was initially implemented by @Virviil so you can consult him for any questions.

from ueberauth_vk.

Virviil avatar Virviil commented on September 2, 2024

@JustMikey Did you check the functionality?
It seems to me, that even when you don't provide state it's still passed as empty parameter like this. (empty state with state=
So, it can be parsed properly with Plug.

from ueberauth_vk.

sobolevn avatar sobolevn commented on September 2, 2024

Just got an email from a person who was not able to use the new version without state.
This is a confirmed bug. @Virviil any ideas how to deal with it?

And could please help me to figure out good testing strategy that both version (with and without state) work?

from ueberauth_vk.

sobolevn avatar sobolevn commented on September 2, 2024

Here's a pull request with a failing test. #22

from ueberauth_vk.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.