Comments (5)
@sobolevn Basically saying I changed cassettes directly, instead of running the code with my token. So, I think that the best testing strategy will be run it with real VK requests.
I can try to do it myself - but then I'll ask you to make testing.md
file with description how to add tokens, which tests to run and so one.
The fastest fix is to add one more handle_callback!
implementation without state
in pattern matching.
Better way will be to test different VK responses and develop suitable code.
from ueberauth_vk.
Oh, I see. @JustMikey can you provide a fix?
This feature was initially implemented by @Virviil so you can consult him for any questions.
from ueberauth_vk.
@JustMikey Did you check the functionality?
It seems to me, that even when you don't provide state it's still passed as empty parameter like this. (empty state with state=
So, it can be parsed properly with Plug.
from ueberauth_vk.
Just got an email from a person who was not able to use the new version without state
.
This is a confirmed bug. @Virviil any ideas how to deal with it?
And could please help me to figure out good testing strategy that both version (with and without state
) work?
from ueberauth_vk.
Here's a pull request with a failing test. #22
from ueberauth_vk.
Related Issues (15)
- User's email is not fetched HOT 2
- Current vk.com API version is deprecated, all requests are failing HOT 2
- Application module is not available with Distillery releases
- Unlock oauth2 HOT 1
- Elixir 1.4 support
- release on hex HOT 2
- Update docs
- Image fetching doesn't work correctly HOT 5
- Upgrade dependencies and elixir version HOT 1
- Error after successful authentication: "no function clause matching in List.first/1" HOT 1
- Release a new version
- %Ueberauth.Auth.Info{} is population wrong HOT 1
- Add tests HOT 2
- Problems with OAuth2 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ueberauth_vk.