GithubHelp home page GithubHelp logo

Comments (2)

UEWBot avatar UEWBot commented on May 31, 2024

I think we hit the error because the first CentreCount added is for an eliminated power. Because the year is the final year for the game, we set the game to is_finished and save it. That means recalculating the scores for the game, which retrieves the centre counts for the final year from the db, most of which don't exist. The one that does exist is zero, giving a score of 0/0.

We actually don't want to recalculate the scores until we have the centre counts for all 7 powers saved to the database, which I think means setting the game to finished from the view code instead.

The same bug probably exists if somebody solos, and I suspect things wouldn't be correct if there were no eliminated powers, too, although we might not get an exception in that case).

from dipvis.

UEWBot avatar UEWBot commented on May 31, 2024

Fixed by commit 6eabb82

from dipvis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.