GithubHelp home page GithubHelp logo

Comments (5)

ug0 avatar ug0 commented on August 15, 2024 1

#79 has been merged.

from aliyun_oss.

ug0 avatar ug0 commented on August 15, 2024

Hi, @c4710n, thanks for your suggestion. I agree the global configuration is something we need to change. Your solution sounds perfect to me. It would be great if you can implement this. I'll be more than happy and grateful to accept a PR.

from aliyun_oss.

c4710n avatar c4710n commented on August 15, 2024

@ug0. I'm very happy that you like my idea. ;-)

The first step I would like to do is to mix format this repo. Then I can adjust the code without worrying about code style.

I notice that this repo already has a .formatter.exs:

# Used by "mix format"
[
  inputs: ["{mix,.formatter}.exs", "{config,lib,test}/**/*.{ex,exs}"]
]

It's ok to use it. But, before using it, I want to confirm your preference on line_length, the default 98 or a customized one?

For me, either choice is fine. It's just a execution of mix format.

from aliyun_oss.

ug0 avatar ug0 commented on August 15, 2024

It's ok to use it. But, before using it, I want to confirm your preference on line_length, the default 98 or a customized one?

The default is fine.

from aliyun_oss.

c4710n avatar c4710n commented on August 15, 2024

The default is fine.

Got it.

I have created a PR which formats the existing code. - #79

Then, I'll work toward the goal.

from aliyun_oss.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.