Empty byte array fails to decode properly. about go

[ugorji]

why should this work?

[aarondl]

Because it works for other data types, and an empty array has a strictly different nuance than a nil array.

[ugorji]

my msgpack-fu is not on high right now. can you explain what the bytes mean? (ie what is test1 supposed to be?)

[aarondl]

0x91 means an array of one object (this reflects the struct if created with StructToArray), 0x90 means empty array (the array of bytes).

If someone sends a message that contains an array of bytes normally, but it happens to be empty and rather than sending nil or nothing at all they send an empty array (0x90), the decoding fails.

[ugorji]

Ah - got it now.

This is a corner case that may require code architecture changes to address.

When we decode, we look at the type of value you are decoding into, and then expect one of a set of ways to decode it.

If you have []Byte, or anything that resembles a sequence of bytes, we expect the stream the msgpack BinXXX or StrXXX. Let me look into adding the check for "if an array and len=0", before erroring out. Sending update soon.

[ugorji]

A quick hack wasn't enough. Your position is strong. A []byte is also an array, and we should be able to decode it from a msgpack array, whether the length is 0 or not. My fix should cover that.

Thanks.