GithubHelp home page GithubHelp logo

Comments (6)

christopherthielen avatar christopherthielen commented on July 16, 2024

I'm compiling before publishing to npm. Are you fetching the git repo or something?

http://npmcdn.com/ui-router-ng1-to-ng2

from angular-hybrid.

jmlopez-rod avatar jmlopez-rod commented on July 16, 2024

A possible issue is that in package.json you have

"main": "ng1-to-ng2",

instead of

"main": "ng1-to-ng2.js",

I did obtain the compiled js file with npm but somehow typescript was picking up the ts version. The above should fix this problem. Also, is there a way to make it webpack friendly as well? Using your compiled version uses System which is not defined when I build. For now I'm having to copy your file into my project to try it out.

from angular-hybrid.

davidstellini avatar davidstellini commented on July 16, 2024

I was unaware that you can throw a different version on npm than on github

#7

from angular-hybrid.

davidstellini avatar davidstellini commented on July 16, 2024

Also the System.register() in the compiled JS file is a very valid point, it would be problematic to get it to work with something like webpack.

from angular-hybrid.

christopherthielen avatar christopherthielen commented on July 16, 2024

Totally agree, thanks for pointing that out.

from angular-hybrid.

christopherthielen avatar christopherthielen commented on July 16, 2024

Version 1.0.10 now points to main: 'ng1-to-ng2.js', and is a UMD bundle using webpack.

from angular-hybrid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.