GithubHelp home page GithubHelp logo

Comments (11)

christopherthielen avatar christopherthielen commented on April 26, 2024 1

and done 👍

from angular.

christopherthielen avatar christopherthielen commented on April 26, 2024

ui-router-rx is a non-optional dependency.

Before beta.4 it was "baked in" to ui-router-ng2. In b0a672f#diff-2bc0b928896a1b6b3e2115a09fab1e0a I moved the code to its own project and refactored it to be a ui-router plugin.

The dependency should automatically get included because of the dependency in package.json

from angular.

christopherthielen avatar christopherthielen commented on April 26, 2024

Follow up questions:

Are you using angular-cli? Webpack? SystemJS? UMD Bundles?

How did you update to beta.4? npm install [email protected]?

from angular.

trumbitta avatar trumbitta commented on April 26, 2024

Thanks for the prompt reply :)

I was coming back to add that the application is an hybrid one via ng1-to-ng2.

I already verified the dependency gets installed inside node_modules.

Answers to your questions: latest Webpack 1.x, and updated to beta.4 changing the version number in package.json then npm prune && npm install.

from angular.

christopherthielen avatar christopherthielen commented on April 26, 2024

I see. The ng1-to-ng2 story is going to change soon.

In beta.3, we were building ng1 and ng2 code from a mono-repository. We split the repositories out for beta.4. We also separated the release cycles (so ng1 has rc.1, while ng2 has beta.4).

The ng1-to-ng2 code will have to change to address this. We will have "blessed" combinations of ng1-to-ng2, ui-router-core, angular-ui-router, and ui-router-ng2 when we release a new ng1-to-ng2.

ng1-to-ng2 currently is tied to the beta.3 releases. It will not work until it's updated for the new split repositories/projects. This shouldn't be terribly difficult, but I want to release ui-router-ng2 beta.5 first.

If you'd like to help with ng1-to-ng2, I've got the code compiling again. You could try building from master if you like. The story shouldn't change much for webpack/bundler users, but the UMD bundles will be changing significantly (all the ui-router libs -- core, ng1, ng2, rx -- will be bundled together)

from angular.

trumbitta avatar trumbitta commented on April 26, 2024

I've got an hour or so, so I'm going to try to build it from master. I'll get back to you as soon as I have something to report 👍

from angular.

christopherthielen avatar christopherthielen commented on April 26, 2024

I'm just about to commit the updates to ng1-to-ng2

from angular.

trumbitta avatar trumbitta commented on April 26, 2024

Getting Error: Error at app/app.module.ts:12:51: Cannot find module 'ui-router-ng1-to-ng2'. at startup.

package.json: "ui-router-ng1-to-ng2": "git+https://github.com/ui-router/ng1-to-ng2.git#4e1050e0af77462d5bffad238b37a7d649052006",

Everything seems fine inside node_modules

from angular.

christopherthielen avatar christopherthielen commented on April 26, 2024

I know what the problem is. That project needs a "prepublish" step for installs like that to work. Give me a few minutes to write one.

from angular.

christopherthielen avatar christopherthielen commented on April 26, 2024

Try again.

Also, I'm on gitter at https://gitter.im/angular-ui/ui-router might be easier to chat about this

from angular.

trumbitta avatar trumbitta commented on April 26, 2024

Status update for passers-by: after a few failed attempts on my end, we decided it would be better if I just wait for the upcoming new release of ng1-to-ng2 before updating to 1.0.0.beta-4 :)

from angular.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.