_.extend implementation breaks in IE11 when string is passed in about core

[christopherthielen]

UI-Router shouldn't be calling extend with a string;

can you show me how to reproduce this?

You can start here:
http://plnkr.co/edit/CcxVK5hq4DmfUqoO4K1B?p=preview

[alalonde]

Here is a demonstration: http://plnkr.co/edit/Oybvbw1nrMFXy9yy2m1G?p=preview

Click 'vendor list' and then 'new vendor' and see the stack trace.

The problem is in the onSuccess transition -- the use case is to detect when the state has been reloaded. In IE it throws an error as soon as you leave that state though.

[christopherthielen]

@alalonde thanks for the plunker.

The API for onSuccess does not take a string. It takes an object with to, from, entering, exiting, or retained properties.

I think you would want $transitions.onSuccess({ exiting: $state.current.name, entering: $state.current.name } ... to detect when the state is being reloaded.

Note you should always deregister hooks in $onDestroy that were registered by a component
Also note that the hook must use a higher priority, otherwise the $onDestroy is invoked before the hook can be fired.
http://plnkr.co/edit/IoTItAoF1ah3iTqd9hHA?p=preview

Note: if you use uiCanExit then you can avoid the manual deregistration:
http://plnkr.co/edit/PUMmoIGKyF1NEX8sFeWG?p=info

Im closing this because the reported issue (_extend and IE) is due to passing invalid arguments to the API

[alalonde]

Thanks for the tips. When I isolated the issue I ended up switching the hook to use the to/from format you mentioned. The string used to work in beta.3, but no matter; seems to work now.