Allow sending to more than one recipient about django-post_office

[selwin]

We could perhaps introduce a kwarg "split_recipients" (other naming suggestions welcome) to "mail.send".

[ivans083]

it's quite annoying that it sends multiple emails rather than one to the recipient_list as expected. Adding an optional argument should be ok, but definitely the default behavior should be sending just one email. This is important as it also doesn't support adding people in +cc.

[selwin]

I'm open to adding this feature. Any ideas on how to implement this?

Sent from my phone

On Jan 29, 2014, at 7:01 PM, ivans083 [email protected] wrote:

it's quite annoying that it sends multiple emails rather than one to the recipient_list as expected. Adding an optional argument should be ok, but definitely the default behavior should be sending just one email. This is important as it also doesn't support adding people in +cc.

—
Reply to this email directly or view it on GitHub.

[ivans083]

In mail.py:
emails = [create(sender, recipient, subject, message, html_message, context,
scheduled_time, headers, priority, commit)
for recipient in recipients]

create should take the list of recipients rather than iterating recipients

[evgenyfadeev]

Can this be implemented via user groups as well as individual users? Ideally when mails are sent the "to" field would not disclose other recipients.

Maybe the Email model could be related as M2M to users and groups.

[selwin]

I've been thinking about this in the past few days. We should also add cc, bcc fields that allows multiple email addresses.

So this would look like:

mail.send(
    to=[user_1],
    cc=[user_2],
    bcc=[user3],
    # Other arguments
)

I'll have to find the time to implement this though. I have other features I want to prioritize over this so pull requests are welcome :)

[dnelson86]

Hi,

I hacked this in since I need it. Below are the changes to mail.py and models.py (no DB changes needed with this approach):

In mail.py send():

    emails = [create(sender, ",".join(recipients), subject, message, html_message,
                     context, scheduled_time, headers, template, priority,
                     render_on_delivery, commit=commit)]
#    emails = [create(sender, recipient, subject, message, html_message,
#                     context, scheduled_time, headers, template, priority,
#                     render_on_delivery, commit=commit)
#              for recipient in recipients]

In models.py Email:

    to = models.CharField(max_length=254)
    #to = models.EmailField(max_length=254)

In models.py Email->email_message():

            msg = EmailMessage(subject, message, self.from_email,
                               self.to.split(","), connection=connection,
                               headers=self.headers)
#            msg = EmailMessage(subject, message, self.from_email,
#                               [self.to], connection=connection,
#                               headers=self.headers)

[evgenyfadeev]

Hello,

Sorry if this is not in line with your thoughts, but I thought it might be
good to still have one receiver per message and at the same time
be able to message multiple users - either by list of emails,
list of AuthUser objects or members of a specific group.

Also - after trying the app I've found that there is a record in the
database per email sent. This in nice, but not practical when you
send thousands of emails. One per campaign might be nicer to have,
or perhaps have a separate entry for "Campaigns"

Thanks for working on this app.

On Tue, May 6, 2014 at 6:40 PM, Dylan Nelson [email protected]:

Hi,

I hacked this in since I need it. Below are the changes to mail.py and
models.py (no DB changes needed with this approach):

In mail.py send():

emails = [create(sender, ",".join(recipients), subject, message, html_message,
                 context, scheduled_time, headers, template, priority,
                 render_on_delivery, commit=commit)]

emails = [create(sender, recipient, subject, message, html_message,

context, scheduled_time, headers, template, priority,

render_on_delivery, commit=commit)

for recipient in recipients]

In models.py Email:

to = models.CharField(max_length=254)
#to = models.EmailField(max_length=254)

In models.py Email->email_message():

        msg = EmailMessage(subject, message, self.from_email,
                           self.to.split(","), connection=connection,
                           headers=self.headers)

msg = EmailMessage(subject, message, self.from_email,

[self.to], connection=connection,

headers=self.headers)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-42362949
.

Askbot
Valparaiso, Chile
skype: evgeny-fadeev

[selwin]

@evgenyfadeev you should check one the render_on_delivery option introduced in 0.8.0 and log_level later in the series. It allows you to store content only once in EmailTemplate, I built that with newsletter/campaign type usage in mind.

Content is only stored once in template, yet you still get the benefit of using context variables. All that plus the parallel processing and more flexible logging options allow us to efficiently send millions on email :).

You can do:

for user in User.objects.all():
    mail.send(user.email, template=template,
              render_on_delivery=True, context={'name': user.username},
              log_level=1)

[stefan-mihaila]

@selwin I want to implement cc and bcc fields and send one email to multiple recipients. Do you think it would be better to add cc and bcc fields to the Email model and store the list of recipients as a comma separated string or add distinct models (like ToRecipient, CcRecipient and BccRecipient) and store each recipient address as a separate entry using a ForeignKey to the Email?

I will make a pull request when I'm done.

[selwin]

@stefan-mihaila please implement cc and bcc fields as comma separated email addresses. Thanks for working on this :)

[selwin]

FYI, Django has a CommaSeparatedIntegerField implemented in core so if you could just make something similar for email addresses it would be great

[stefan-mihaila]

Thanks to you for contributing! I'll work on it this weekend.

[stefan-mihaila]

I created a pull request for this issue.

[selwin]

Fixed in #63