GithubHelp home page GithubHelp logo

Comments (1)

glenn-jocher avatar glenn-jocher commented on June 4, 2024

@Buckler89 hey there 👋, thanks a lot for such a detailed report! You've pointed out a very valid concern regarding the unintended alteration of bounding box formats within the bbox_areas property.

Indeed, the current design where Bboxes.areas() changes the bounding box format to XYXY without reverting back could lead to unexpected behaviours, especially in pipelines where the original format is essential for subsequent processes.

To address this issue, a potential solution might involve modifying the Bboxes.areas() to perform format conversion and area computation without altering the original format state of the bounding boxes. Here's a quick idea of how that could be structured:

def areas(self, revert_format=True):
    """Return box areas, optionally reverting to original format."""
    original_format = self.format
    self.convert("xyxy")
    areas = (self.bboxes[:, 2] - self.bboxes[:, 0]) * (self.bboxes[:, 3] - self.bboxes[:, 1])
    if revert_format:
        self.convert(original_format)
    return areas

This modification suggests adding a parameter to control whether the bounding boxes should revert to their original format after computing the areas. By default, it reverts to maintaining the original behavior unless specified otherwise.

I'll forward this to our team to verify and implement a fix efficiently. Thanks again for catching this and for your detailed explanation! 😄 If there's anything more you'd like to discuss or suggest, feel free to share!

from ultralytics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.