Comments (8)
@MidnightDesign Thanks for the issue.
Actually there is. Similar package umpirsky/currency-list is used in moneyphp/money.
See https://github.com/moneyphp/money/blob/master/src%2FISOCurrencies.php#L31-L46.
from country-list.
Do you really think this is the way to go? It seems pretty fragile to me.
@Seldaek Can you give us your Composer-opinion on this?
from country-list.
This is safe as long as there are no batshit crazy custom installers in the game that relocate packages randomly. It's a similar pattern to what we do for binaries to find the autoloader really https://github.com/Seldaek/jsonlint/blob/master/bin/jsonlint#L20 and has the same constraint (no crazy custom installers).
from country-list.
Thanks for your opinion!
But isn't that a little different? In the case you mentioned, you're trying to initialize the autoloader itself. When autoloading is already wired up, I don't think that's the way to do it.
from country-list.
Well.. yeah you can for sure use a class to do the resolution, I am not saying your method is wrong, but IMO both are valid workable solutions. One uses a class as indirection which adds overhead while the other potentially does useless io/filesystem stats, but it's marginal either way I think.
from country-list.
Just wanted to add that it is not a primary use case to use this package with composer. Mainly because it is not limited to PHP at all.
from country-list.
Yeah, I got that. That's why I chose this title for the issue. :)
from country-list.
:)
from country-list.
Related Issues (20)
- Holy See is no valid country HOT 1
- Spanish (Latin America) HOT 3
- 请修复一下**为**** HOT 1
- Missing "BV" country code. HOT 1
- `XK` country code HOT 1
- Dial Codes Support HOT 1
- Allow using with PHP > 8.0 HOT 1
- Pseudo-Bidi & Pseudo-Accents entries HOT 1
- Kosovo - country code XK is missing HOT 2
- How to use with PHP HOT 1
- Add UK alias for United Kingdom in the country list. HOT 10
- How to contribute? HOT 3
- NPM package removed due to malicious code HOT 1
- country name correction for Palestine HOT 1
- "Syrian Arab Republic" country incorrectly named as "Syria" HOT 1
- Make IC - Canary Islands - available in all languages HOT 1
- Add tools to convert to different cases (PascalCase, snake_case, camleCase, kebab-case, etc...) HOT 2
- "Taiwan" should be corrected to “Taiwan, China” or "Taipei, China" HOT 2
- Missing Kosovo HOT 4
- Add XI for Northern Ireland after Brexit HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from country-list.