Comments (6)
Do you have a link to the specs?
from django-ipware.
Specs are the same as in your documentation: https://en.wikipedia.org/wiki/Reserved_IP_addresses. But what I mean is using https://docs.python.org/3/library/ipaddress.html for detecting whether an address actually belongs to a given subnet. I created a version which does this and it seems to work nicely. I also added a couple of tests to check for more private IP addresses.
from django-ipware.
@Karimerto I am looking forward to your PR. Please have in mind that we still need to support py 2.7. As the link you provided is only in py 3. I like the idea as ipaddress is part of python and we don't create another depency.
Alternatively, we can pin use python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*',
and make the next version py 3.0 only.
from django-ipware.
Actually the same ipaddress
library exists in both python versions, 2 and 3. I forked a copy of this and pushed the necessary changes. However it currently supports only python 3, as python 2's version of ipaddress
library wants the string to be unicode (as in u'something'
). I'll see if I can easily create something that'll support both 2 and 3.
from django-ipware.
I have looked at your work and it looks great. If you can make it fallback on what we have now for 2.7, it would be a great PR. Thx
from django-ipware.
@Karimerto django-ipware is on its way to being deprecated.
With that said, I have a python package that is going to replace it.
Have a look at python-ipware and if works for you switch to it.
Feedback is welcomed.
from django-ipware.
Related Issues (20)
- Add a notice informing users that ports are not stripped HOT 1
- Update django-ipware to use python-ipware underneath - Help Needed HOT 1
- Pypi description completely empty HOT 3
- 'NoneType' object has no attribute 'META' HOT 3
- proxy_count and proxy_trusted_ips returning None on localhost/ngrok HOT 1
- Release this package with Django 3.2 support HOT 2
- Looking for 1-2 contributors to de-risk the project as it is now used by many projects HOT 5
- setup.py license classifier does not match LICENSE HOT 3
- Precedence order is not regarded when all IPs are not routable HOT 4
- Update the logic to better handle client IP determination for both routable and private HOT 3
- Suggestion - define default settings value HOT 2
- Any IP starting with `::` is treated as private HOT 7
- Feature proposal: get IP address in list of IPs based on `ip_count` HOT 1
- 'NoneType' object has no attribute 'strip' when META['REMOTE_ADDR'] is None HOT 1
- This module treats addresses like 2001:0db8:1234:: as routable HOT 1
- Upgrade django-ipware with enhancements HOT 1
- What is the difference between getting IP from django-ipware versus stream HOT 3
- ipware ignoring precedence order HOT 4
- [Feature Request] Add support for Django 4.2 HOT 1
- Use `python-ipware` underneath
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-ipware.