Comments (4)
It's worth mentioning that Stimulus Reflex has added these kind of callbacks which I've used for this very same thing.
from motion.
Thank you for the detailed feature request, @davidalejandroaguilar !
A temporary workaround that you can use for this is something like:
def render_in(*)
Time.use_zone(current_user.timezone) { super }
end
I agree that this is cumbersome though, and an around_render
callback is a much better fit.
With the current design, I think the most straight-forward thing to do is to add before_
/after_
/around_
callbacks for render
, motion
, broadcast
, and periodic_timer
.
- I think it will be awkward to also have a
before_render
instance method withViewComponent::Base
(but of course removing it is beyond the scope ofMotion
). - If you want to have a callback that runs around everything, you have to define 4 around callbacks.
@latortuga @Gmfholley I'm interested in your thoughts.
from motion.
Another thought after sleeping on it: We haven't used the word "action" yet. We could before_action
/after_action
/around_around
callbacks that run around everything instead of (or in addition to) the callbacks I suggested above.
from motion.
This feature is now available as around_action
in 0.3.0
. See #27 for details.
from motion.
Related Issues (20)
- Motion does not work on older IOS versions
- Motion v0.5.0 does not work with ViewComponent >= v2.35.0 HOT 1
- Demo site does not load, errors out HOT 2
- [Question] What's the purpose of data-motion-key and -state? HOT 3
- [Question] Preventing unauthorized access to a resource's stream HOT 2
- It doesn't seem that Motion supports passing in a form builder object. HOT 1
- [Discussion] Debouncing input and the mystery of event targets HOT 8
- Slow application startup times in some projects HOT 24
- Intermittent exceptions when disconnecting a component and leaking memory HOT 10
- `session`, `cookies`, and `current_user` are only accessible while rendering HOT 5
- Motion component is unable to have a handle to a form object HOT 7
- Transpiled Event Serialization Issue HOT 1
- Add test helpers for generating events for testing
- Custom element attributes are lost on component re-render
- Events capture HOT 1
- [question] broadcast to multiple clients HOT 3
- Compatibility issue with Rails 6.1 ? HOT 12
- Domain lost after page change HOT 4
- Add better support for custom logging HOT 2
- Documentation: Clarify that info from request is lost after first re-render HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from motion.