GithubHelp home page GithubHelp logo

Comments (4)

davidalejandroaguilar avatar davidalejandroaguilar commented on May 26, 2024 1

It's worth mentioning that Stimulus Reflex has added these kind of callbacks which I've used for this very same thing.

from motion.

alecdotninja avatar alecdotninja commented on May 26, 2024 1

Thank you for the detailed feature request, @davidalejandroaguilar !

A temporary workaround that you can use for this is something like:

def render_in(*)
  Time.use_zone(current_user.timezone) { super }
end

I agree that this is cumbersome though, and an around_render callback is a much better fit.

With the current design, I think the most straight-forward thing to do is to add before_/after_/around_ callbacks for render, motion, broadcast, and periodic_timer.

  1. I think it will be awkward to also have a before_render instance method with ViewComponent::Base (but of course removing it is beyond the scope of Motion).
  2. If you want to have a callback that runs around everything, you have to define 4 around callbacks.

@latortuga @Gmfholley I'm interested in your thoughts.

from motion.

alecdotninja avatar alecdotninja commented on May 26, 2024 1

Another thought after sleeping on it: We haven't used the word "action" yet. We could before_action/after_action/around_around callbacks that run around everything instead of (or in addition to) the callbacks I suggested above.

from motion.

alecdotninja avatar alecdotninja commented on May 26, 2024 1

This feature is now available as around_action in 0.3.0. See #27 for details.

from motion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.