{multiple-input} pattern change not enough about yii2-multiple-input

[lorinczelod]

I using this change in 'jquery.multipleInput.js' to fix this problem

 for (i in settings.jsTemplates) {
                jsTemplate = settings.jsTemplates[i].replaceAll('{multiple-index}', data.currentIndex);
                jsTemplate = jsTemplate.replaceAll('{multiple_index}', data.currentIndex); // new code
                window.eval(jsTemplate);
            }

[unclead]

I think its better to use multiple_input key everywhere. Name multiple-input uses only for internal aims
Want to make a pr?

[lorinczelod]

Yes, I want, but I don't know how can I make PR. Could you show me? Do you have a chat?

[unclead]

You can use yii2 git workflow: https://github.com/yiisoft/yii2/blob/master/docs/internals/git-workflow.md

[lorinczelod]

Thank you your guidance!

2015-10-13 15:45 GMT+03:00 Eugene Tupikov [email protected]:

You can use yii2 git workflow:
https://github.com/yiisoft/yii2/blob/master/docs/internals/git-workflow.md

—
Reply to this email directly or view it on GitHub
#46 (comment)
.

[unclead]

Closed via 12b8de4