Comments (19)
interesting. If I open an incognito tab it works fine there too. Something must be cached in my browser from the previous beta version. Blah! Thanks for all the help!!!!!
from understrap-child.
I'm dying. That's what I already thought of but I didn't come across this easy thing.
Thanks a lot, of course it's fine now!
from understrap-child.
Hi!
Can it be that you use different versions of Bootstrap?
Since Bootstrap 4 Alpha 6 the markup should looks like this:
https://github.com/holger1411/understrap/blob/master/header.php
So if you using the new markup but with BS 4 Alpha 5 it will not work.
Its a common problem becasue if you update your parent theme you have to update the dependencies in your child theme, too.
A bit nasty but since BS4 is still in alpha it happends sometimes in a new release.
Make sure that the package.json in your child theme folder include this:
"bootstrap": "^4.0.0-alpha.6",
and that you run
npm install
to install the correct version.
Than recompile you SASS code with:
gulp scss-for-prod
from understrap-child.
I'm having a similar issue, but my responsive menu expands properly and then immediately closes just as the animation finishes. I've updated my header.php file to match what you mentioned, but I cannot for the life of me figure out why it's behaving this way.
When I try to run the gulp command you provided above, I'm seeing an error:
understrap-child xxx$ gulp scss-for-prod
[09:10:50] Using gulpfile /projects/wordpress-theme/wp-content/themes/understrap-child/gulpfile.js
[09:10:50] Starting 'scss-for-prod'...
[09:10:50] 'scss-for-prod' errored after 10 ms
[09:10:50] ReferenceError: clone is not defined
at Gulp.<anonymous> (/projects/wordpress-theme/wp-content/themes/understrap-child/gulpfile.js:46:29)
at module.exports (/projects/wordpress-theme/wp-content/themes/understrap-child/node_modules/orchestrator/lib/runTask.js:34:7)
at Gulp.Orchestrator._runTask (/projects/wordpress-theme/wp-content/themes/understrap-child/node_modules/orchestrator/index.js:273:3)
at Gulp.Orchestrator._runStep (/projects/wordpress-theme/wp-content/themes/understrap-child/node_modules/orchestrator/index.js:214:10)
at Gulp.Orchestrator.start (/projects/wordpress-theme/wp-content/themes/understrap-child/node_modules/orchestrator/index.js:134:8)
at /Users/xxx/.nvm/versions/node/v7.0.0/lib/node_modules/gulp-cli/lib/versioned/^3.7.0/index.js:46:20
at _combinedTickCallback (internal/process/next_tick.js:67:7)
at process._tickCallback (internal/process/next_tick.js:98:9)
at Module.runMain (module.js:609:11)
at run (bootstrap_node.js:382:7)
from understrap-child.
Could you find this:
var clone = require('gulp-clone');
in your gulpfile.js of your child?
If not its seems you use an older version of this file. Its the best to copy the package.json and the gulpfile.js from here:
https://github.com/holger1411/understrap-child
Than run
npm install
than
gulp scripts
<- just to make sure it is not a JS problem
followed by
gulp scss-for-prod
from understrap-child.
I don't actually see that require('gulp-clone');
in the repo:
https://github.com/holger1411/understrap-child/blob/master/gulpfile.js
it is in the package.json though
from understrap-child.
I also had to add var merge = require('gulp-merge');
to the gulpfile and then the gulp scss-for-prod
command ran successfully.
from understrap-child.
Arhg...ahm...yes...of course...
Seems I don´t merge the parent theme changes to the child theme...
Done it here: c0b0846
from understrap-child.
Unfortunately even after all of that I'm still seeing the same responsive menu behavior:
Any ideas of where else I might look? At this point I'm just pulling things out until I can get anything working.
from understrap-child.
Can you post the URL?
from understrap-child.
Here is a temporary URL: http://xxxxxxxx.ngrok.io/
from understrap-child.
I test it here with Chrome, FF and Safari and it works.
Is JS enabled in your browser? Which browser do you use?
from understrap-child.
whaaaaat. Chrome 55.0.2883.95 on Mac. Yeah, I see that it works on Safari now. I tried logging out as an administrator and that didn't seem to help either. I wonder if it's just some kind of beta issue? There are lots of Github issues related to the navbar in the bootstrap repo
from understrap-child.
My gif was taken with Chrome Version 55.0.2883.95 (64-bit) on a Mac, too ...
from understrap-child.
Hi Holger, thanks for your detailed reply. I couldn't fix it yet. The markup was just right, even changing to original markup didn't change a thing. I'm on 0.5.3 and 0.1.9 since today.
When you come across another possible fix feel free to text me again.
Thanks
~Daniél
from understrap-child.
@piedrola : Can u post the URL? And do you see the same behavior on our demo website: https://understrap.com/understrap ?
from understrap-child.
Thanks Holger, I pushed it on a test-environment. http://wp12012786.server-he.de/www/testwp/
Your demo site is working correctly. Can't imagine that there's a problem with my browser/workspace. Clear cache etc.
Thanks for having a look!
EDIT: of course the markup beside the menu may be bad as I only focused on the menu yet
from understrap-child.
Hi!
You site just stopps loading at some point.
Behind this HTML tag:
<section id="start-flex" class="outer">
...
</section>
Nothing happends anymore. No closing </htm>
or </body>
tag etc.
Because this your site did not load the wordpress footer, and because of this it did not load the Boostrap JS.
Thats the reason why the hamburger icon menu did not work.
Looks like a PHP problem or a missing PHP file
from understrap-child.
Great, I will check that Holger. Thanks a lot.
from understrap-child.
Related Issues (20)
- Upgrade guidance from 1.0.1 to 1.1 HOT 1
- I know this is my own ignorance, but I can not get a Bootstrap 5 sticky footer to work with the lastest Understrap-Child HOT 8
- Problem with npm run watch-bs HOT 1
- can't add functions in custom-javascript.js HOT 10
- theme cache HOT 2
- Uncaught ReferenceError: bootstrap is not defined HOT 1
- Understrap Import appears to do nothing HOT 1
- Where to put theme images for CSS background images? HOT 3
- Add single files or all .css files in copy assets HOT 2
- Off-Canvas menu behaviour is broken HOT 2
- Issues with npm run watch in the understrap-child HOT 2
- Changes to 'custom-editor-style.css' not reflected in 'custom-editor-style.min.css'? HOT 2
- Remove Customizations HOT 6
- Scss not transpiling & Recent Post filter not working for Custom Post Types
- console.log("Something"); from custom-javascript.js outputs nothing? HOT 1
- Make understrap child the default theme HOT 2
- Custom query members category - understrap_pagination not working HOT 4
- navbar-branding.php strips out my HTML somehow HOT 3
- wordpress not reading css from child theme. HOT 5
- Removing language menu from header results in visual glitch HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from understrap-child.