Crashes when opening images from other apps (Content Provider) about leafpic

[dnldsht]

fixed this issue soon i will release v0.3 with a lot of improvements and bugs solved

EDIT: also hidden feature is now working!

[rugk]

I have a response from the developers of the other app (loosely translated):

Surprisingly the NPE after an ACTION_VIEW intent also happens with file URIs.

You should not rely on Uri.getPath(). For file URIs this may work, but it will definitely fail with content URIs as these are only virtual paths. The only way to correctly open a content URI is to use the ContentResolver and methods such as openInputStream().

[craftyguy]

I also see this when opening a picture directly from Snap camera (camera in CyanogenMod 13) in leafpic

[rugk]

@craftyguy Interestingly I cannot reproduce it with the default camera app in CM13, but if it is the same error.
Would you mind also adding your logcat log? (Or at least compare if it is the same/similar)

[craftyguy]

@rugk

It's the same NPE as far as I can tell. Here's the logcat snippet:

05-06 07:14:52.779 W/System.err(5996): java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.String.replace(java.lang.CharSequence, java.lang.CharSequence)' on a null object reference
05-06 07:14:52.786 W/System.err(5996):  at com.horaapps.leafpic.utils.StringUtils.quoteReplace(StringUtils.java:157)
05-06 07:14:52.786 W/System.err(5996):  at com.horaapps.leafpic.Base.CustomAlbumsHandler.checkAndCreateAlbum(CustomAlbumsHandler.java:67)
05-06 07:14:52.786 W/System.err(5996):  at com.horaapps.leafpic.Base.CustomAlbumsHandler.getSettings(CustomAlbumsHandler.java:48)
05-06 07:14:52.786 W/System.err(5996):  at com.horaapps.leafpic.Base.Album.setSettings(Album.java:109)
05-06 07:14:52.786 W/System.err(5996):  at com.horaapps.leafpic.Base.Album.<init>(Album.java:78)
05-06 07:14:52.786 W/System.err(5996):  at com.horaapps.leafpic.PhotoPagerActivity.onCreate(PhotoPagerActivity.java:101)
05-06 07:14:52.786 W/System.err(5996):  at android.app.Activity.performCreate(Activity.java:6251)
05-06 07:14:52.786 W/System.err(5996):  at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1108)
05-06 07:14:52.786 W/System.err(5996):  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2403)
05-06 07:14:52.786 W/System.err(5996):  at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2510)
05-06 07:14:52.786 W/System.err(5996):  at android.app.ActivityThread.-wrap11(ActivityThread.java)
05-06 07:14:52.786 W/System.err(5996):  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1363)
05-06 07:14:52.786 W/System.err(5996):  at android.os.Handler.dispatchMessage(Handler.java:102)
05-06 07:14:52.786 W/System.err(5996):  at android.os.Looper.loop(Looper.java:148)
05-06 07:14:52.786 W/System.err(5996):  at android.app.ActivityThread.main(ActivityThread.java:5461)
05-06 07:14:52.786 W/System.err(5996):  at java.lang.reflect.Method.invoke(Native Method)
05-06 07:14:52.786 W/System.err(5996):  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
05-06 07:14:52.786 W/System.err(5996):  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
05-06 07:14:52.795 D/AndroidRuntime(5996): Shutting down VM
05-06 07:14:52.800 E/AndroidRuntime(5996): FATAL EXCEPTION: main
05-06 07:14:52.800 E/AndroidRuntime(5996): Process: com.horaapps.leafpic, PID: 5996
05-06 07:14:52.800 E/AndroidRuntime(5996): Theme: themes:{default=overlay:com.ciaostudio.ciaoui, iconPack:org.twelf.cmtheme, fontPkg:com.ciaostudio.ciaoui, com.android.systemui=overlay:com.ciaostudio.ciaoui, com.android.systemui.navbar=overlay:system}
05-06 07:14:52.800 E/AndroidRuntime(5996): java.lang.RuntimeException: Unable to resume activity {com.horaapps.leafpic/com.horaapps.leafpic.PhotoPagerActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.RelativeLayout.setBackgroundColor(int)' on a null object reference
05-06 07:14:52.800 E/AndroidRuntime(5996):  at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3137)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3168)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2515)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at android.app.ActivityThread.-wrap11(ActivityThread.java)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1363)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at android.os.Handler.dispatchMessage(Handler.java:102)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at android.os.Looper.loop(Looper.java:148)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at android.app.ActivityThread.main(ActivityThread.java:5461)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at java.lang.reflect.Method.invoke(Native Method)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
05-06 07:14:52.800 E/AndroidRuntime(5996): Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.RelativeLayout.setBackgroundColor(int)' on a null object reference
05-06 07:14:52.800 E/AndroidRuntime(5996):  at com.horaapps.leafpic.PhotoPagerActivity.setupUI(PhotoPagerActivity.java:216)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at com.horaapps.leafpic.PhotoPagerActivity.onResume(PhotoPagerActivity.java:251)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1259)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at android.app.Activity.performResume(Activity.java:6327)
05-06 07:14:52.800 E/AndroidRuntime(5996):  at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3126)
05-06 07:14:52.800 E/AndroidRuntime(5996):  ... 10 more
05-06 07:14:52.804 W/ActivityManager(3043):   Force finishing activity com.horaapps.leafpic/.PhotoPagerActivity
05-06 07:14:52.810 W/ActivityManager(3043):   Force finishing activity org.cyanogenmod.snap/com.android.camera.CameraLauncher

[licaon-kter]

@dnldsht
Two things before release:

• pull translations
• tag the release so F-Droid can pick it up ;)

[dnldsht]

Sure just making some clean

On Fri, May 6, 2016, 7:21 PM licaon-kter [email protected] wrote:

@dnldsht https://github.com/DNLDsht
Two things before release:

• pull translations
• tag the release so F-Droid can pick it up ;)

—
You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#148 (comment)

[craftyguy]

I can confirm that this issue is resolved for me with the latest release (0.3), thanks for the quick fix!

[rugk]

I can confirm it too, BTW.