GithubHelp home page GithubHelp logo

Comments (7)

DaniRey avatar DaniRey commented on June 16, 2024

I think that's a nice idea. How would you control which annotations NEBA should record and provide information upon? I see two options - either it simply records all annotations available or it might be configured in the Spring context.
What do you think?

from neba.

huberchrigu avatar huberchrigu commented on June 16, 2024

The PostProcessor-like service should provide the annotations it is looking for I'd say. Also depends on the NEBA implementation, which I don't know in detail

from neba.

olaf-otto avatar olaf-otto commented on June 16, 2024

I do not think it is safe to make any assumptions what the desired behavior of a post processor is, and specifying what annotation(s) must apply to a model is likely to be insufficient in some situations. Remember that post processors may alter the entire model, e.g. return a proxy instread of the original model and so forth. Besides, it could be relatively cumbersome to specify the desired annotations - what if one is interested in a combination of annotations or wants to filter on specific annotation attributes?

However, I see two different solution approaches:

  • No change. The applications must maintain a cache of the types they reflect on
  • We provide the post processors with metadata by means of a public interface, and they can use that meta data instead of reflecting on the model.

The latter is my favorit solution, since it provides decent performance and a maximum of flexibility

from neba.

huberchrigu avatar huberchrigu commented on June 16, 2024

I will make a suggestion...

from neba.

olaf-otto avatar olaf-otto commented on June 16, 2024

I have re-named this issue. In this use case, Post-Processors are employed to achieve injecting custom values based on custom annotations. Thus, we are not talking about a post processor but about supporting custom injectors.

from neba.

olaf-otto avatar olaf-otto commented on June 16, 2024

Pull request: #27

from neba.

olaf-otto avatar olaf-otto commented on June 16, 2024

Implemented, merged, done!

from neba.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.