GithubHelp home page GithubHelp logo

Comments (4)

isra17 avatar isra17 commented on July 28, 2024

This look like a guenine issue, either the compiler should pick up the lifetime issue or it should not crash. Are you able to get a simple test case that reliably reproduce the issue?
Thanks!

from unicorn-rs.

isra17 avatar isra17 commented on July 28, 2024

Got it! Need to Box the callback otherwise Rust might allocate them on the stack...
Test case here: isra17@5cb2c4e

The Unicorn interface should be fixed accordingly.

from unicorn-rs.

isra17 avatar isra17 commented on July 28, 2024

Disregard last comment, crash come from the Unicorn object pointer being first saved in the callback data. The pointer however is first stored on the init function stack. Returning the object from the function move the value to the parent fram and invalidate the saved pointer. I think this can be fixed by forcing Box<Self> on self in add_*_hook functions.

from unicorn-rs.

oblivia-simplex avatar oblivia-simplex commented on July 28, 2024

Hey, just catching up with this thread now. Glad to hear I stumbled on a worthwhile bug. I'll pull the fix, and see if I get better mileage out of it. Thanks.

from unicorn-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.