GithubHelp home page GithubHelp logo

ERC-777 token support about v1-contracts HOT 2 OPEN

uniswap avatar uniswap commented on August 24, 2024
ERC-777 token support

from v1-contracts.

Comments (2)

MicahZoltu avatar MicahZoltu commented on August 24, 2024 2

While I disagree that tokens that call into the recipient are inherently unsafe, I don't think that is relevant here since Uniswap cannot dictate how tokens function internally. Since Uniswap supports arbitrary tokens (one of its biggest selling points!), I think it needs to assume the worst and that the token will do all of the worst things possible when called.

from v1-contracts.

haydenadams avatar haydenadams commented on August 24, 2024

More broadly speaking, the Uniswap contracts incorrectly assume that the token contract being called will not call out into any third party

Imo tokens that do this are inherently unsafe and should not be used.

That said, mutex has already been added in the v2 branch
https://github.com/Uniswap/contracts-vyper/blob/v2/contracts/uniswap_exchange.vy#L66

Hopefully EIP 2200 makes it into the Istanbul (final decision this friday) so its not a huge gas hit.

from v1-contracts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.