getTradeDetails: unexpected executionRate about v2-sdk

[NoahZinsmeister]

hi @sbrichards, thanks for this. you're correct that you need to multiply buyAmount by 10**<decimals>, glad that seems to have fixed the issue! going to close this, feel free to reopen if you're seeing any other weird behavior.

(also, to answer one of your questions, executionRate is the actual rate that the trade will get, including price slippage)

[samajammin]

Also, do you mind explaining what tradeDetails.outputAmount represents in this situation (and inputAmount)? Given that I'm passing in TRADE_EXACT.OUTPUT to getTradeDetails() in order to buy exactly the buyAmount of tokens, I expected tradeDetails.outputAmount.amount to be the same value as buyAmount, which it's not. Thanks in advance!

[samajammin]

I believe I figured it out - the tradeAmount calculation should multiply by 10^decimals, not just multiply by decimals.

const tradeAmount: BigNumber = buyAmount.multipliedBy(decimals);

Should be:

const tradeAmount: BigNumber = buyAmount.multipliedBy(10 ** decimals);

That yields the expected results.

If my logic is correct, please feel free to close the issue 😄