GithubHelp home page GithubHelp logo

Comments (4)

moodysalem avatar moodysalem commented on June 2, 2024

is this a difference between v3-core and v3-core-optimism or the code is the same b/t the two?

from v3-core-optimism.

NoahZinsmeister avatar NoahZinsmeister commented on June 2, 2024

@zgfzgf do you have a test case reproduction of this bug? in your example, i'm already seeing a potential issue, index would never be 3 for the given self blockTimestamps, index always represents the most recently updated entry, in this case 9

from v3-core-optimism.

zgfzgf avatar zgfzgf commented on June 2, 2024

when old cardinality 10. may index 3
because first 0-9
then start 0

when index=3
update cardinality =100

https://github.com/Uniswap/uniswap-v3-core-optimism/blob/da89f9b88a1616be1ef075ad4313e8aeb3532906/contracts/libraries/Oracle.sol#L78-L101

from v3-core-optimism.

zgfzgf avatar zgfzgf commented on June 2, 2024

if it is bug.
createPool and then increaseObservationCardinalityNext(65535). no problem.
or modify contract code.
@NoahZinsmeister

from v3-core-optimism.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.