GithubHelp home page GithubHelp logo

Comments (2)

rdeago avatar rdeago commented on June 14, 2024

Hello @jswigart, thanks for opening this issue.

Non-literally quoting myself from Slack:

The zip file is opened with FileAccess.ReadWrite and FileShare.Read (the default):
https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.cs,120
We should use FileAccess.Read in the constructor call, as ReadWrite is not actualy needed.

There's no need for an option, as EmbedIO considers a Zip file an immutable file provider.

While we're on the subject, it wouldn't hurt to specify FileShare.Read explicitly too.

from embedio.

rdeago avatar rdeago commented on June 14, 2024

This is the line to fix in version 3 (branch v3.x).

This is the line to fix in version 4 (branch master).

Any kind soul willing to submit a PR?

from embedio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.