Comments (3)
@PlasmaPower thanks for the code-review and feedback points. I'm taking a couple of days off from coding to give myself rest, but will certainly get on them. There are some bits that I consider as belonging in the "won't fix" pile (or at least "not my problem" pile). Masking IP addresses is a great idea, but I think it's something that realistically needs to be left to the end user, not baked into NanoFusion. I'm prepared to be persuaded otherwise, but that's my thinking for now.
I hadn't quite worked out the point of the zValue. The scheme "works" if zValues are all empty, which is why I thought it was fine to calculate deterministically (also helped me with debugging, because output was consistent each time I ran it). I see now that it's meant to be a random variable to prevent key re-use attacks. Thanks for pointing that out.
from nanofusion.
The issues with R commitments not being validated should now be fixed in the mixing context. The PhaseTracker should prevent moving on to signing until all commitments are checked.
from nanofusion.
Thanks, I'm liking the new phase architecture a lot better :)
from nanofusion.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nanofusion.