GithubHelp home page GithubHelp logo

Comments (2)

jsyoon01 avatar jsyoon01 commented on August 18, 2024

I think I figured out the problem.
Let's say we are logged in as an instructor with Karen and Karen will be teaching csc209. By the changes made in the merge pull request #148, our application only asks to fetch relevant course data from the database (i.e., the courses that Karen will be teaching, csc209). However, let's say there's an applicant who has several course preferences, (csc148, csc209) for example. Upon selecting this applicant's last name, it will try to access csc148 data but then csc148 data was not fetched from the database, which is causing the problem.

I guess there are two ways of solving this.

  1. We can try to load necessary course info every time we click some applicant's last name.
  2. We can fetch all the course data from the database at the beginning and filter which courses to show on the instructor's panel.

I would like to ask you guys on which option sounds better. Both approaches seem OK to me.

from tapp-cp.

nigef avatar nigef commented on August 18, 2024

Thanks for looking into that @jsyoon01

Probably try to avoid option 2. Fetching all that data seems unnecessary for just a couple sections in a modal. And that may get more complicated for different rounds, and sessions.

Upon selecting this applicant's last name, it will try to access csc148 data

If I understand option 1 correctly @jsyoon01, to fix the bug, it should be uncomplicated to set up a fetch for csc148 data when opening a modal, even if its not one of the instructor's courses. It is not unreasonable to do a new API fetch at opening each modal.

But that being said, I don't fully understand for example, why do we want to fetch csc148 data in a modal if a prof does not have that class in their instructor view?

from tapp-cp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.