Comments (2)
I think I figured out the problem.
Let's say we are logged in as an instructor with Karen and Karen will be teaching csc209. By the changes made in the merge pull request #148, our application only asks to fetch relevant course data from the database (i.e., the courses that Karen will be teaching, csc209). However, let's say there's an applicant who has several course preferences, (csc148, csc209) for example. Upon selecting this applicant's last name, it will try to access csc148 data but then csc148 data was not fetched from the database, which is causing the problem.
I guess there are two ways of solving this.
- We can try to load necessary course info every time we click some applicant's last name.
- We can fetch all the course data from the database at the beginning and filter which courses to show on the instructor's panel.
I would like to ask you guys on which option sounds better. Both approaches seem OK to me.
from tapp-cp.
Thanks for looking into that @jsyoon01
Probably try to avoid option 2. Fetching all that data seems unnecessary for just a couple sections in a modal. And that may get more complicated for different rounds, and sessions.
Upon selecting this applicant's last name, it will try to access csc148 data
If I understand option 1 correctly @jsyoon01, to fix the bug, it should be uncomplicated to set up a fetch for csc148 data when opening a modal, even if its not one of the instructor's courses. It is not unreasonable to do a new API fetch at opening each modal.
But that being said, I don't fully understand for example, why do we want to fetch csc148 data in a modal if a prof does not have that class in their instructor view?
from tapp-cp.
Related Issues (20)
- rounds should be sorted in the tapp drop down list
- exporting is broken
- Change defaults to remove real people's email address HOT 4
- Loading a student with an apostrophe in name fails HOT 1
- No "X" icon for Applicants by Course tab when 3 courses are selected.
- Courses Assigned through applicant modal reappearing if not canceled or confirmed.
- Create instructor landing page
- Fix and enhance DDAH UI HOT 1
- Create historical report for TAs
- Create application form
- utorids should be sorted in edit instructor dropdown on courses view
- Instructor Panel modal
- Instructor Panel layout
- Instructor Panel URI
- Instructor Panel "Dept." Filter HOT 1
- Admin, Summary View. NaN, Infinity, <empty>.
- Import: empty courses and preferences breaks importer
- Need ability to add and remove admins
- Unintuitive UI for importing JSON
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tapp-cp.