Comments (8)
I'd like to work on this, will you assign it to me?
from react-todo.
@serickson67 great. Thanks
- It should move to add item also.
- No I don't think circular make sense.
from react-todo.
@serickson67 thanks for helping out with this. Merged the PR and closed the ticket.
from react-todo.
Thanks, I'm on it!
from react-todo.
Hi - I've made some good progress on this, but have some questions about how you would like certain cases to behave:
- Do you want the up arrow key to allow the cursor to move just between the created ToDoItems or should it also allow you to arrow up into the 'Add Item' text field?
- Do you want the up arrow/down arrow to be circular? Meaning, if the cursor is at the top of the list of items, and you hit the up arrow it will move the cursor to the bottom? And vice versa for the down arrow at the bottom of the list of items.
from react-todo.
Please review my pull request: #41
from react-todo.
Hey - I linked my pull request above, but it doesn't seem linked to this issue. Sorry, I'm fairly new to contributing to open-source projects, could you tell me how I should have linked it?
from react-todo.
Hey - please don't forget to review my pull request with the updates - and also, can you please add the hacktoberfest label to this issue and the pull request so I can get credit there? I appreciate it. @kamalkishor1991
from react-todo.
Related Issues (20)
- Create a Checkbox component similar to MUI checkbox component using class bases css. HOT 3
- Create a Container component similar to MUI Container component using class bases css.
- Create a TextField component similar to MUI TextField component using class bases css. HOT 9
- Create a Accordion, AccordionDetails, AccordionSummary component similar to MUI component using class based css. HOT 5
- Create a AccordionDetails component similar to MUI AccordionDetails component using class bases css.
- Wrap text with limit of 1200 chars HOT 18
- Add jest tests with github action to execute test on every PR and merge HOT 5
- Add new todo item on pressing enter in between todo list rows HOT 12
- On hitting space and then hitting the enter button a blank todo list is being created HOT 1
- update on delete icon HOT 5
- full dark mode HOT 13
- Handle pressing back in the beginning of the todo item HOT 8
- Add undo/redo support across items add and removal HOT 11
- Text typing in input field rather than going down to list when typing HOT 6
- One level hierarchy support HOT 15
- Missing Components HOT 4
- require more accurate instruction for Contributor guided HOT 1
- Cannot run storybook HOT 2
- Node Version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-todo.