Is it expected behaviour that input$<plot>_click does not produce an event when the same selection is clicked a 2nd time? about upsetjs_r

[sgratzl]

see e.g. https://github.com/upsetjs/upsetjs_r/blob/main/shiny/selectionP/app.R

[RichardJActon]

OK so I've been trying to solve this problem in some different ways and I think there may actually be a bug here. These are the approaches I've tried:

library(shiny)
library(upsetjs)
library(purrr)
library(dplyr)

set_list_2_combinations <- function(set_list) {
	set_list <- set_list[
		order(purrr::map_int(set_list, length), decreasing = TRUE)
	]
	set_names <- names(set_list)
	purrr::map(seq_along(set_names), ~{
		lst <- combn(set_names, .x) %>% as.data.frame() %>% as.list()
		names(lst) <- purrr::map_chr(lst, ~paste0(.x, collapse = "&"))
		lst
	}) %>% unlist(recursive = FALSE)
}

set_list <- list("A" = c(1,2,3,4,5),"B" = c(1,2,3),"C" = c(2,6,7,8))
combinations <- c(list("none" = ""), set_list_2_combinations(set_list))

# Proxy ----
# Based on the Docs this seemed like the most efficient way to implement
# setting setSelection value by updating the values with the proxy
# functions but this did not work, the setSelection did not update on click
ui_proxy <- fluidPage(
	shiny::sidebarLayout(
		shiny::sidebarPanel(
			actionButton("reset_selection", "Reset Selection")
		),
		shiny::mainPanel(
			upsetjs::upsetjsOutput("upset_plot")
		)
	)
)

server_proxy <- function(input, output, session) {
	
	output$upset_plot <- upsetjs::renderUpsetjs({
		upsetjs::upsetjs() %>% 
			upsetjs::fromList(set_list)
	})
	
	observeEvent(input$upset_plot_click, {
		req(input$upset_plot_click$name)
		upsetjs::upsetjsProxy("upset_plot", session) %>% 
			upsetjs::setSelection(strsplit(
				isolate(input$upset_plot_click$name), split = "&"
			)[[1]])
	})
	
	observeEvent(input$reset_selection, {
		upsetjs::upsetjsProxy("upset_plot", session) %>% 
			upsetjs::setSelection("")
			# NB empty string not NULL, NULL does not reset the selection
	}) 
}

shinyApp(ui_proxy, server_proxy)

# input ----
# I went back to basics to see If I could get it working with and input
# to select the highlighted set and re-rendering the plot when the selection 
# changed. Abandoning the update on click/reset on click twice temporarily
ui_input <- fluidPage(
	shiny::sidebarLayout(
		shiny::sidebarPanel(
			selectInput(
				"set_2_highlight", "Set to highlight",
				choices = names(combinations)
			)
		),
		shiny::mainPanel(
			upsetjs::upsetjsOutput("upset_plot")
		)
	)
)

server_input <- function(input, output, session) {
	
	output$upset_plot <- upsetjs::renderUpsetjs({
		upsetjs::upsetjs() %>% 
			upsetjs::fromList(set_list) %>%
			upsetjs::setSelection(combinations[[input$set_2_highlight]])
	})
}

shinyApp(ui_input, server_input)


# reactive values ----
# I next tried a compromise still re-rendering the plot in place of proxy
# but with a reactive value that would respond to clicks in place of a direct
# input - this also did not work
ui_reactive <- fluidPage(
	shiny::sidebarLayout(
		shiny::sidebarPanel(
			actionButton("reset_selection", "Reset Selection"),
			verbatimTextOutput("split_sel")
		),
		shiny::mainPanel(
			upsetjs::upsetjsOutput("upset_plot")
		)
	)
)

server_reactive <- function(input, output, session) {
	
	output$upset_plot <- upsetjs::renderUpsetjs({
		upsetjs::upsetjs() %>% 
			upsetjs::fromList(set_list) %>%
			upsetjs::setSelection(upset_selection$selected_sets)
	})
	
	upset_selection <- reactiveValues(selected_sets = "")
	
	observeEvent(input$upset_plot_click, {
		req(input$upset_plot_click$name)
		upset_selection$selected_sets <- strsplit(
			input$upset_plot_click$name, split = "&"
		)[[1]]
	})
	
	observeEvent(input$reset_selection, {
		upset_selection$selected_sets <- ""
	}) 
	
	# debug info
	output$split_sel <- reactive({
		strsplit(
			input$upset_plot_click$name, split = "&"
		)[[1]]	
	})
}

shinyApp(ui_reactive, server_reactive)

[sgratzl]

re same selection: this is an odd behavior of rshiny, since it triggers an event with the same data, it won't be transferred to the server since the reactive state hasn't changed. currently investigating a workaround, e.g. by adding a nonce like an event timestamp