ResourceLoader return state selector based values about uptrend-redux-modules

[orther]

It looks like none of this extra madness would be necessary if I just fully implemented the ResourceLoader component as detailed in #19 In the issue it's explained that if the resource was normalized by setting the entityType prop then the results passed to child render prop is the entities rather than the resource(s) and so it would be default be based on state.

My current plan is to update ResourceLoader to return raw resource response data, entities data, and then update the result prop to hold either response data or entities data based on whether the resource was normalized by setting a entityType prop value.

[orther]

Actually it would make more sense to match the resourceHelpers selectors as described in #17 and follow this conventions:

  // returned data
  resource, // <- resource data (when normalized returns entity id(s))
  result,   // <- if the resource was normalized into entities this
            //    holds the list of entities, otherwise returns the
            //    resource data (non-normalized)

With that said, we should provide access to the raw API response data too for features like pagination. So we may want to add another prop that holds extraneous values. Will consider...

[orther]

Current thinking is added a requestResult prop that has the following data from the resource request success action payload:

const requestResult = {
      api: payload.api,
      data: payload.data,
      entities: payload.entities,
      entityType: payload.entityType,
      resource: payload.resource,
    }

[orther]

Final thoughts before stopping for the night....

By providing the requestResult object as outlined above I was nicely able to use EntityList component to load the entities from state. By doing so updates to state reflect in the rendered list.

        {status.success &&
          locationList &&
          entities &&
          <EntityList entityIds={entities} entityType="planAppLocation">
            {locationList => {
              console.log('locationList', locationList);
              return (
                <OrgPlanAppLocationOverviewPage
                  orgId={orgId}
                  planAppId={planAppId}
                  locationList={locationList}
                />
              );
            }}
          </EntityList>}

I created a branch with EntityList and EntityDetail created inside the ResourceLoader component but I feel like that is the wrong solution. Instead a separate component should be made that simply joins the two. Branch here: https://github.com/uptrend-tech/uptrend-redux-modules/tree/resource-loader-include-entities-experimental

[orther]

Closing since we are using the EntityDetail and EntityList components to solve this for now. Still not sure what the best path forward is to remove even more boilerplate.