GithubHelp home page GithubHelp logo

Comments (5)

fardog avatar fardog commented on August 26, 2024

on merge strategy:

Contributors should be working in their own forks, with a branch for each feature/bug/enhancement they are working on. PRs should be made from those branches to our master branch.

PRs can be made with commit history (if looking for comments), but after comments (and two +1's from maintainers), they should rebase off current master, squash to a single commit, and force push to their feature branch. PRs will only be merged once squashed down to a single commit.

Maintainers will then merge (via the "big green button") after travis reports back success. Any PR that cannot be merged via the big green button will need to be fixed prior to acceptance.

from objectstate.

fardog avatar fardog commented on August 26, 2024

on rights:

a note on assignment of rights (as is a requirement of the APACHE-v2 license) will probably need to be stated.

from objectstate.

AWinterman avatar AWinterman commented on August 26, 2024

The advantage of merging via the big green button is that then people get to see that their work was accepted?

from objectstate.

fardog avatar fardog commented on August 26, 2024

they get to see that their work was accepted, and in the commit history you'll see which PRs were merged when, and be able to follow them to the closed PR, where the comments will be preserved. I think this does a few things:

  1. Makes it very clear what's made it in
  2. Gives people that are looking to contribute a way to see what has been accepted very easily
  3. Makes it clear that we accept PRs, and that they make it in (good for community building)

from objectstate.

fardog avatar fardog commented on August 26, 2024

merged #15

from objectstate.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.