Comments (5)
on merge strategy:
Contributors should be working in their own forks, with a branch for each feature/bug/enhancement they are working on. PRs should be made from those branches to our master
branch.
PRs can be made with commit history (if looking for comments), but after comments (and two +1's from maintainers), they should rebase off current master, squash to a single commit, and force push to their feature branch. PRs will only be merged once squashed down to a single commit.
Maintainers will then merge (via the "big green button") after travis reports back success. Any PR that cannot be merged via the big green button will need to be fixed prior to acceptance.
from objectstate.
on rights:
a note on assignment of rights (as is a requirement of the APACHE-v2 license) will probably need to be stated.
from objectstate.
The advantage of merging via the big green button is that then people get to see that their work was accepted?
from objectstate.
they get to see that their work was accepted, and in the commit history you'll see which PRs were merged when, and be able to follow them to the closed PR, where the comments will be preserved. I think this does a few things:
- Makes it very clear what's made it in
- Gives people that are looking to contribute a way to see what has been accepted very easily
- Makes it clear that we accept PRs, and that they make it in (good for community building)
from objectstate.
merged #15
from objectstate.
Related Issues (7)
- Lets open source this repository!
- os.include, os.snapshot need to be removed HOT 1
- ObjectState copy on write, and emit a copy of its internal state object. HOT 4
- nested `.wait()`s yield surprising results HOT 1
- OS should not emit if its state has not changed. HOT 1
- Add Code of Conduct to CONTRIBUTING, or create and link one
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from objectstate.