GithubHelp home page GithubHelp logo

Comments (8)

dotansimha avatar dotansimha commented on May 27, 2024

Hi @gurusamy , can you please share more information and a reproduction?

from graphql-modules.

gurusamy avatar gurusamy commented on May 27, 2024

Hi @dotansimha we are not able to reproduce in dev environment. It is happening on production when traffic is high. We could not reproducible on dev load testing also. We are injecting ExecutionContext in singleton class. Any guess what could be the issue?

Below is the sample code

import { Injectable, ExecutionContext } from 'graphql-modules'
@Injectable()
export class SampleProvider extends BaseProvider {
    constructor() {}
   
    @ExecutionContext()
    private context: ExecutionContext
   
    someMethod(data) {
      const value = this.callAPI(data)
    }
}


export class BaseProvider  {
    constructor() {}
   
    private context: ExecutionContext
   
    callAPI() {
      console.log(this.context.reqContext);
      //Call API
    }
}




const resolvers = {
    Query: {
        myQuery(root, args, context, info) {
          context.injector.get(SampleProvider).someMethod(args)
      }
    }
}

from graphql-modules.

gurusamy avatar gurusamy commented on May 27, 2024

@dotansimha We got another error for the same scenario
Maximum call stack size exceeded\n at Map.delete (<anonymous>)\n at destroyContextAndItsChildren (/data/instance/node_modules/graphql-modules/index.js:201:37)\n at destroyContextAndItsChildren (/data/instance/node_modules/graphql-modules/index.js:206:13)\n at destroyContextAndItsChildren (/data/instance/node_modules/graphql-modules/index.js:206:13)\n at destroyContextAndItsChildren (/data/instance/node_modules/graphql-modules/index.js:206:13)\n at destroyContextAndItsChildren (/data/instance/node_modules/graphql-modules/index.js:206:13)\n at destroyContextAndItsChildren (/data/instance/node_modules/graphql-modules/index.js:206:13)\n at destroyContextAndItsChildren (/data/instance/node_modules/graphql-modules/index.js:206:13)\n at destroyContextAndItsChildren (/data/instance/node_modules/graphql-modules/index.js:206:13)\n at destroyContextAndItsChildren (/data/instance/node_modules/graphql-modules/index.js:206:13

from graphql-modules.

Simon12121 avatar Simon12121 commented on May 27, 2024

Hi @gurusamy and @dotansimha, I have also received this error. However, for me it only occurs when I make database queries with many return objects. Have you already found a solution for this problem?

from graphql-modules.

ardatan avatar ardatan commented on May 27, 2024

We need a failing test or a reproduction on CodeSandbox or StackBlitz

from graphql-modules.

Simon12121 avatar Simon12121 commented on May 27, 2024

Hi @ardatan, I have created a repo on github for reproduction: https://github.com/Simon12121/graphql-modules-bug-replication. Because the error happens only when I make a query to MongoDb with many return objects, you would have to create an Atlas Free cluster. Maybe it happens also with other databases. I have stored my connection-string under environment/.env in the variable MONGO_DB_URI (not present in repo). First you would need to run the Mutation 'initFeatureTest' and the errors happens then when querying 'getAllNames'. I hope you can reproduce the error.

from graphql-modules.

enisdenjo avatar enisdenjo commented on May 27, 2024

Hey @Simon12121 and @gurusamy, thanks for your patience! Can you try out [email protected] please? #2461 has potential to fix your issue too. Thanks!

from graphql-modules.

enisdenjo avatar enisdenjo commented on May 27, 2024

Fixed in [email protected] with #2461. Please try it out!

from graphql-modules.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.